fix(blog): acquitter les GUID apres livraison XMPP

2026-09-12 15:33:59 +02:00
parent 6bb8ad1ed1
commit 75dd78ee1e
6 changed files with 182 additions and 11 deletions
@@ -1040,6 +1040,110 @@ def test_runner_blog_success_delivers_articles_into_xmpp_message_external_info(
    assert xmpp_message.external_info.blog_articles[0].title == "Test Article"


+@pytest.mark.parametrize(
+    ("channel_kind", "dry_run", "should_acknowledge"),
+    [
+        ("success", False, True),
+        ("false", False, False),
+        ("exception", False, False),
+        ("none", False, False),
+        ("success", True, False),
+    ],
+)
+def test_runner_acknowledges_blog_only_after_confirmed_xmpp_delivery(
+    pipeline_inputs: tuple[Lesson, Homework],
+    tmp_path: Any,
+    channel_kind: str,
+    dry_run: bool,
+    should_acknowledge: bool,
+) -> None:
+    """Les GUID RSS restent rejouables tant que XMPP n'a pas confirmé l'envoi.
+
+    :param pipeline_inputs: Données Pronote de test.
+    :param tmp_path: Répertoire temporaire pour l'état RSS.
+    :param channel_kind: Comportement du canal XMPP simulé.
+    :param dry_run: Active ou non le mode simulation.
+    :param should_acknowledge: Indique si l'état RSS doit être acquitté.
+    """
+    lesson, homework = pipeline_inputs
+    calls: list[str] = []
+    state_file = tmp_path / "blog-state.json"
+
+    class SuccessfulBlogClient:
+        """Client RSS renvoyant un article non encore livré."""
+
+        def fetch_and_parse(
+            self,
+            *,
+            known_guids: frozenset[str] | None = None,
+            etag: str | None = None,
+            last_modified: str | None = None,
+        ) -> BlogRSSFetchResult:
+            """Retourne un article et des en-têtes de cache déterministes.
+
+            :param known_guids: GUID déjà connus, ignorés dans ce faux client.
+            :param etag: ETag mémorisé, ignoré dans ce faux client.
+            :param last_modified: Date HTTP mémorisée, ignorée dans ce faux client.
+            :return: Résultat RSS avec un article à livrer.
+            :rtype: BlogRSSFetchResult
+            """
+            del known_guids, etag, last_modified
+            return BlogRSSFetchResult(
+                articles=(
+                    BlogArticle(
+                        id="article-to-deliver",
+                        title="Article à livrer",
+                        url="https://example.com/article-to-deliver",
+                        published_at=datetime(2026, 9, 8, 12, 0),
+                        updated_at=None,
+                        category=None,
+                        author=None,
+                        content_html="<p>Contenu</p>",
+                        content_text="Contenu",
+                    ),
+                ),
+                etag="etag-after-delivery",
+                last_modified="Tue, 08 Sep 2026 12:00:00 GMT",
+            )
+
+    channel: Any
+    if channel_kind == "success":
+        channel = StubChannel(calls)
+    elif channel_kind == "false":
+        channel = FailingChannel()
+    elif channel_kind == "exception":
+        channel = ExceptionalChannel()
+    else:
+        channel = None
+
+    runner = PipelineRunner(
+        settings=Settings(blog=Settings().blog.model_copy(update={"enabled": True})),
+        pronote_fetcher=StubFetcher(calls, lesson, homework),
+        caldav_synchronizer=lambda data, settings: successful_sync_result(),
+        agenda_comparator=cast("AgendaComparator | None", StubComparator(calls)),
+        blog_client=cast("BlogRSSClient | None", SuccessfulBlogClient()),
+        blog_state=BlogRSSState(state_file),
+        channel=channel,
+        dry_run=dry_run,
+        now_provider=lambda: datetime(2026, 9, 8, 7, 0),
+    )
+
+    data, errors = runner.run()
+
+    assert data is not None
+    if should_acknowledge:
+        acknowledged_state = BlogRSSState(state_file)
+        assert acknowledged_state.get_known_guids() == frozenset({"article-to-deliver"})
+        assert acknowledged_state.get_cache_headers() == (
+            "etag-after-delivery",
+            "Tue, 08 Sep 2026 12:00:00 GMT",
+        )
+    else:
+        assert not state_file.exists()
+    if channel_kind in {"false", "exception"}:
+        assert any(error.step == "send" for error in errors)
+
+
 def test_runner_secret_redaction_in_pipeline_errors(
    pipeline_inputs: tuple[Lesson, Homework],
 ) -> None: