test+docs(M4): tests get_lessons/get_homeworks + repli unique + doc sync
Tests: - test_pronote_client : get_lessons/get_homeworks success + error propagation, ENT resolution, factory parent/student, mode dégradé messages/informations (ConnectionError, TimeoutError) - test_fallback : repli unique ICAL→pronotepy et PRONOTEPY→iCal, filtre target_date, fetch_messages log + re-raise sans secrets, aucune source configurée → PipelineCriticalError - 59 tests passent (16 client + 17 fallback + 26 iCal) Documentation: - TODO.md : 7 items M4 cochés, contrat repli corrigé (unique, non réciproque) selon décision D4 - GUIDE_DEV_PYTHON.md : get_agenda_fallback → get_lessons/get_homeworks, pronote_url/account_type ajoutés au modèle + env vars + .env.example, AgendaSource StrEnum, §5.1.8 fallback contract mis à jour (repli unique) Co-authored-by: opencode/test-engineer <test-engineer@agents.invalid> Co-authored-by: opencode/tech-writer <tech-writer@agents.invalid>
This commit is contained in:
@@ -31,7 +31,8 @@ def test_protocol_methods(mocker: pytest_mock.MockerFixture) -> None:
|
||||
"""
|
||||
assert hasattr(PronoteClientProtocol, "get_messages")
|
||||
assert hasattr(PronoteClientProtocol, "get_informations")
|
||||
assert hasattr(PronoteClientProtocol, "get_agenda_fallback")
|
||||
assert hasattr(PronoteClientProtocol, "get_lessons")
|
||||
assert hasattr(PronoteClientProtocol, "get_homeworks")
|
||||
|
||||
|
||||
# --- Client with mocked pronotepy ---
|
||||
@@ -45,9 +46,11 @@ def pronote_settings() -> PronoteSettings:
|
||||
:rtype: PronoteSettings
|
||||
"""
|
||||
return PronoteSettings(
|
||||
pronote_url="https://pronote.example.com",
|
||||
username="testuser",
|
||||
password=SecretStr("testpass"),
|
||||
ent="testent",
|
||||
ent="bordeaux",
|
||||
account_type="parent",
|
||||
)
|
||||
|
||||
|
||||
@@ -82,7 +85,7 @@ def test_get_messages_success(
|
||||
mock_message.seen = True
|
||||
mock_discussion.messages = [mock_message]
|
||||
mock_client.discussions.return_value = [mock_discussion]
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_messages()
|
||||
@@ -111,7 +114,7 @@ def test_get_messages_empty_on_error(
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.discussions.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_messages()
|
||||
@@ -138,7 +141,7 @@ def test_get_informations_success(
|
||||
mock_info.read = False
|
||||
mock_info.survey = True
|
||||
mock_client.information_and_surveys.return_value = [mock_info]
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_informations()
|
||||
@@ -167,7 +170,7 @@ def test_get_informations_empty_on_error(
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.information_and_surveys.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_informations()
|
||||
@@ -175,10 +178,10 @@ def test_get_informations_empty_on_error(
|
||||
assert messages == []
|
||||
|
||||
|
||||
def test_get_agenda_fallback_success(
|
||||
def test_get_lessons_success(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_agenda_fallback retourne un tuple de listes en cas de succès.
|
||||
"""Vérifie que get_lessons retourne une liste de Lesson en cas de succès.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
@@ -201,20 +204,11 @@ def test_get_agenda_fallback_success(
|
||||
mock_content.description = "Lesson content"
|
||||
mock_lesson.content = mock_content
|
||||
|
||||
# Mock des devoirs
|
||||
mock_hw = mocker.MagicMock()
|
||||
mock_hw.id = "hw-101"
|
||||
mock_hw.subject = mocker.MagicMock()
|
||||
mock_hw.subject.name = "Maths"
|
||||
mock_hw.date = date(2024, 9, 15)
|
||||
mock_hw.description = "Do your homework"
|
||||
|
||||
mock_client.lessons.return_value = [mock_lesson]
|
||||
mock_client.homework.return_value = [mock_hw]
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
lessons, homeworks = client.get_agenda_fallback(date(2024, 9, 1), date(2024, 9, 30))
|
||||
lessons = client.get_lessons(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
assert isinstance(lessons, list)
|
||||
assert len(lessons) == 1
|
||||
@@ -230,6 +224,32 @@ def test_get_agenda_fallback_success(
|
||||
assert lesson.status == LessonStatus.NORMAL
|
||||
assert lesson.content == "Lesson content"
|
||||
|
||||
|
||||
def test_get_homeworks_success(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_homeworks retourne une liste de Homework en cas de succès.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
|
||||
# Mock des devoirs
|
||||
mock_hw = mocker.MagicMock()
|
||||
mock_hw.id = "hw-101"
|
||||
mock_hw.subject = mocker.MagicMock()
|
||||
mock_hw.subject.name = "Maths"
|
||||
mock_hw.date = date(2024, 9, 15)
|
||||
mock_hw.description = "Do your homework"
|
||||
|
||||
mock_client.homework.return_value = [mock_hw]
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
homeworks = client.get_homeworks(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
assert isinstance(homeworks, list)
|
||||
assert len(homeworks) == 1
|
||||
homework = homeworks[0]
|
||||
@@ -243,10 +263,10 @@ def test_get_agenda_fallback_success(
|
||||
assert homework.html == "Do your homework"
|
||||
|
||||
|
||||
def test_get_agenda_fallback_empty_on_error(
|
||||
def test_get_lessons_propagates_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_agenda_fallback retourne des listes vides en cas d'erreur API.
|
||||
"""Vérifie que get_lessons propage les exceptions API.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
@@ -254,91 +274,166 @@ def test_get_agenda_fallback_empty_on_error(
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.lessons.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
lessons, homeworks = client.get_agenda_fallback(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
assert lessons == []
|
||||
assert homeworks == []
|
||||
with pytest.raises(pronotepy.PronoteAPIError):
|
||||
client.get_lessons(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
|
||||
def test_missing_credentials_returns_empty(empty_pronote_settings: PronoteSettings) -> None:
|
||||
"""Vérifie que les méthodes retournent une liste vide si les identifiants sont manquants.
|
||||
def test_get_homeworks_propagates_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_homeworks propage les exceptions API.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.homework.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
|
||||
with pytest.raises(pronotepy.PronoteAPIError):
|
||||
client.get_homeworks(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
|
||||
def test_missing_credentials_raises(empty_pronote_settings: PronoteSettings) -> None:
|
||||
"""Vérifie que les appels échouent avec ValueError si les identifiants sont manquants.
|
||||
|
||||
:param empty_pronote_settings: Paramètres Pronote avec tous les champs à None.
|
||||
:return: None
|
||||
"""
|
||||
client = PronoteClient(empty_pronote_settings)
|
||||
|
||||
messages = client.get_messages()
|
||||
assert messages == []
|
||||
|
||||
informations = client.get_informations()
|
||||
assert informations == []
|
||||
|
||||
lessons, homeworks = client.get_agenda_fallback(date(2024, 9, 1), date(2024, 9, 30))
|
||||
assert lessons == []
|
||||
assert homeworks == []
|
||||
with pytest.raises(ValueError, match="pronote_url, username, password et ent sont requis"):
|
||||
client._connect()
|
||||
|
||||
|
||||
def test_password_used_in_connection(
|
||||
def test_connect_with_ent_resolution(mocker: pytest_mock.MockerFixture) -> None:
|
||||
"""Vérifie que _resolve_ent retourne le callable attendu pour un ENT connu.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:return: None
|
||||
"""
|
||||
from pronote_sync.sources.pronote.client import _resolve_ent
|
||||
|
||||
resolver = _resolve_ent("bordeaux")
|
||||
assert resolver is not None
|
||||
|
||||
|
||||
def test_connect_with_unknown_ent_raises(mocker: pytest_mock.MockerFixture) -> None:
|
||||
"""Vérifie que _resolve_ent lève ValueError pour un ENT inconnu.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:return: None
|
||||
"""
|
||||
from pronote_sync.sources.pronote.client import _resolve_ent
|
||||
|
||||
with pytest.raises(ValueError) as exc_info:
|
||||
_resolve_ent("inconnu")
|
||||
assert "ENT inconnu : 'inconnu'" in str(exc_info.value)
|
||||
assert "ENT supportés :" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_connect_parent_account_type(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que le mot de passe est bien utilisé pour la connexion.
|
||||
"""Vérifie que account_type='parent' utilise pronotepy.ParentClient.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
# Patch pronotepy.Client to return our mock
|
||||
from pronote_sync.sources.pronote import client as client_module
|
||||
from unittest.mock import Mock
|
||||
|
||||
from pronote_sync.sources.pronote.client import PronoteClient
|
||||
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_discussion = mocker.MagicMock()
|
||||
mock_message = mocker.MagicMock()
|
||||
mock_message.id = "msg-123"
|
||||
mock_message.content = "Test"
|
||||
mock_message.author = "Teacher"
|
||||
mock_message.created = datetime(2024, 9, 1, 10, 0, 0)
|
||||
mock_message.seen = False
|
||||
mock_discussion.messages = [mock_message]
|
||||
mock_discussion.subject = "Test Subject"
|
||||
mock_client.discussions.return_value = [mock_discussion]
|
||||
|
||||
# Patch pronotepy.Client to return our mock
|
||||
mocker.patch.object(client_module, "pronotepy")
|
||||
client_module.pronotepy.Client = lambda u, p, e: mock_client # type: ignore[attr-defined] # noqa: ARG005
|
||||
|
||||
# Setup mock client
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_discussion = mocker.MagicMock()
|
||||
mock_message = mocker.MagicMock()
|
||||
mock_message.id = "msg-123"
|
||||
mock_message.content = "Test"
|
||||
mock_message.author = "Teacher"
|
||||
mock_message.created = datetime(2024, 9, 1, 10, 0, 0)
|
||||
mock_message.seen = False
|
||||
mock_discussion.messages = [mock_message]
|
||||
mock_discussion.subject = "Test Subject"
|
||||
mock_client.discussions.return_value = [mock_discussion]
|
||||
|
||||
# Patch pronotepy.Client to return our mock
|
||||
mocker.patch("pronote_sync.sources.pronote.client.pronotepy.Client", return_value=mock_client)
|
||||
mock_client_class = Mock(return_value=mock_client)
|
||||
mocker.patch("pronotepy.ParentClient", new=mock_client_class)
|
||||
mocker.patch("pronotepy.Client")
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
_ = client.get_messages()
|
||||
_ = client._connect()
|
||||
|
||||
# Vérifie que le client a été créé avec le mot de passe
|
||||
# Le mock de Client doit avoir été appelé avec username, password, ent
|
||||
client_class_mock = client_module.pronotepy.Client # type: ignore[attr-defined]
|
||||
client_class_mock.assert_called_once()
|
||||
call_args = client_class_mock.call_args
|
||||
assert call_args is not None
|
||||
assert len(call_args.args) >= 3
|
||||
assert call_args.args[0] == "testuser"
|
||||
assert call_args.args[1] == "testpass"
|
||||
assert call_args.args[2] == "testent"
|
||||
# Verify ParentClient was used
|
||||
assert mock_client_class.call_count == 1
|
||||
pronotepy.Client.assert_not_called() # type: ignore[attr-defined]
|
||||
|
||||
|
||||
def test_connect_student_account_type(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que account_type='student' utilise pronotepy.Client.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
from unittest.mock import Mock
|
||||
|
||||
from pronote_sync.sources.pronote.client import PronoteClient
|
||||
|
||||
pronote_settings_student = PronoteSettings(
|
||||
pronote_url="https://pronote.example.com",
|
||||
username="testuser",
|
||||
password=SecretStr("testpass"),
|
||||
ent="bordeaux",
|
||||
account_type="student",
|
||||
)
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client_class = Mock(return_value=mock_client)
|
||||
mocker.patch("pronotepy.Client", new=mock_client_class)
|
||||
mocker.patch("pronotepy.ParentClient")
|
||||
|
||||
client = PronoteClient(pronote_settings_student)
|
||||
_ = client._connect()
|
||||
|
||||
# Verify Client was used
|
||||
assert mock_client_class.call_count == 1
|
||||
pronotepy.ParentClient.assert_not_called() # type: ignore[attr-defined]
|
||||
|
||||
|
||||
def test_get_messages_degraded_on_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_messages retourne une liste vide en cas d'erreur réseau.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.discussions.side_effect = ConnectionError("Network error")
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_messages()
|
||||
|
||||
assert messages == []
|
||||
|
||||
|
||||
def test_get_informations_degraded_on_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_informations retourne une liste vide en cas d'erreur réseau.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.information_and_surveys.side_effect = TimeoutError("Timeout")
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_informations()
|
||||
|
||||
assert messages == []
|
||||
|
||||
|
||||
# Ensure trailing newline
|
||||
|
||||
Reference in New Issue
Block a user