Compare commits
3 Commits
feature/m4
...
fix/m4-fix
| Author | SHA1 | Date | |
|---|---|---|---|
|
bb1f90bf5f
|
|||
|
9d9a55ed40
|
|||
|
1b550aa818
|
@@ -1,5 +1,7 @@
|
||||
# --- Pronote ---
|
||||
PRONOTE_ICAL_URL=https://college.ent/pronote/ical/Edt_Jean.ics?icalsecurise=REPLACE_ME&version=2024
|
||||
PRONOTE_URL=https://college.ent/pronote/eleve.html
|
||||
PRONOTE_ACCOUNT_TYPE=parent
|
||||
PRONOTE_USERNAME=parent.dupont
|
||||
PRONOTE_PASSWORD=your_secure_password
|
||||
PRONOTE_ENT=monbureaunumerique
|
||||
|
||||
@@ -139,11 +139,11 @@
|
||||
"type": "Hex High Entropy String",
|
||||
"filename": "GUIDE_DEV_PYTHON.md",
|
||||
"hashed_secret": "90bd1b48e958257948487b90bee080ba5ed00caa",
|
||||
"is_secret": false,
|
||||
"is_verified": true,
|
||||
"line_number": 5117
|
||||
"line_number": 5124,
|
||||
"is_secret": false
|
||||
}
|
||||
]
|
||||
},
|
||||
"generated_at": "2026-09-05T21:51:55Z"
|
||||
"generated_at": "2026-09-06T13:36:29Z"
|
||||
}
|
||||
|
||||
@@ -285,6 +285,8 @@ Le projet utilise **`pydantic-settings`** pour valider et charger la configurati
|
||||
| `PRONOTE_AGENDA_SOURCE` | Source pour l'agenda (`auto`, `ical`, `pronotepy`). | `auto` | `Literal` |
|
||||
| `PRONOTE_HOMEWORK_SOURCE` | Source pour les devoirs (`auto`, `ical`, `pronotepy`). | `auto` | `Literal` |
|
||||
| `PRONOTE_MESSAGES_SOURCE` | Source pour les messages (`pronotepy` uniquement). | `pronotepy` | `Literal` |
|
||||
| `PRONOTE_URL` | URL de l'instance Pronote. | `None` | `str \| None` |
|
||||
| `PRONOTE_ACCOUNT_TYPE` | Type de compte (`student` ou `parent`). | `parent` | `Literal` |
|
||||
| `SYNC_PAST_DAYS` | Nombre de jours dans le passé pour la sync CalDAV. | `7` | `int` |
|
||||
| `SYNC_FUTURE_DAYS` | Nombre de jours dans le futur pour la sync CalDAV. | `30` | `int` |
|
||||
|
||||
@@ -309,6 +311,8 @@ PRONOTE_ICAL_URL=https://college.ent/pronote/ical/Edt_Jean.ics?icalsecurise=REPL
|
||||
PRONOTE_USERNAME=parent.dupont
|
||||
PRONOTE_PASSWORD=your_secure_password
|
||||
PRONOTE_ENT=monbureaunumerique
|
||||
PRONOTE_URL=
|
||||
PRONOTE_ACCOUNT_TYPE=parent
|
||||
|
||||
# Sources (auto = essayer iCal d'abord, puis pronotepy)
|
||||
PRONOTE_AGENDA_SOURCE=auto
|
||||
@@ -369,6 +373,8 @@ class PronoteSettings(BaseSettings):
|
||||
username: Optional[str] = None
|
||||
password: Optional[SecretStr] = None
|
||||
ent: Optional[str] = None
|
||||
pronote_url: Optional[str] = None
|
||||
account_type: Literal["student", "parent"] = "parent"
|
||||
agenda_source: Literal["auto", "ical", "pronotepy"] = "auto"
|
||||
homework_source: Literal["auto", "ical", "pronotepy"] = "auto"
|
||||
messages_source: Literal["pronotepy"] = "pronotepy"
|
||||
@@ -2201,43 +2207,38 @@ class PronoteClient:
|
||||
logger.error(f"Échec de la récupération des informations Pronote: {redact_secrets(str(e))}")
|
||||
return []
|
||||
|
||||
def get_agenda_fallback(self) -> tuple[List[Lesson], List[HomeworkModel]]:
|
||||
def get_lessons(self, start: date, end: date) -> list[Lesson]:
|
||||
"""
|
||||
Récupère l'agenda et les devoirs via pronotepy (repli si iCal échoue).
|
||||
**À utiliser uniquement si PRONOTE_AGENDA_SOURCE=pronotepy ou PRONOTE_HOMEWORK_SOURCE=pronotepy**.
|
||||
Récupère les cours via pronotepy (repli si iCal échoue).
|
||||
Les erreurs sont propagées pour déclencher le repli.
|
||||
"""
|
||||
try:
|
||||
client = self._get_client()
|
||||
client = self._get_client()
|
||||
return [Lesson(
|
||||
id=str(lesson.id),
|
||||
start=lesson.start,
|
||||
end=lesson.end,
|
||||
subject=lesson.subject,
|
||||
teachers=[t.name for t in lesson.teachers],
|
||||
rooms=[r.name for r in lesson.rooms],
|
||||
status=LessonStatus.NORMAL,
|
||||
content=lesson.content,
|
||||
) for lesson in client.lessons(start, end)]
|
||||
|
||||
lessons = []
|
||||
for lesson in client.get_lessons():
|
||||
lessons.append(Lesson(
|
||||
id=str(lesson.id),
|
||||
start=lesson.start,
|
||||
end=lesson.end,
|
||||
subject=lesson.subject,
|
||||
teachers=[t.name for t in lesson.teachers],
|
||||
rooms=[r.name for r in lesson.rooms],
|
||||
status=LessonStatus.NORMAL, # À adapter selon les données
|
||||
content=lesson.content,
|
||||
))
|
||||
|
||||
homeworks = []
|
||||
for hw in client.get_homework():
|
||||
homeworks.append(HomeworkModel(
|
||||
id=str(hw.id),
|
||||
subject=hw.subject,
|
||||
teachers=[t.name for t in hw.teachers],
|
||||
assigned_on=hw.given_date,
|
||||
due_on=hw.due_date,
|
||||
text=hw.description,
|
||||
html=hw.description, # pronotepy ne fournit pas de HTML
|
||||
))
|
||||
|
||||
return lessons, homeworks
|
||||
except PronoteAPIError as e:
|
||||
logger.error(f"Échec de la récupération de l'agenda via pronotepy: {redact_secrets(str(e))}")
|
||||
return [], []
|
||||
def get_homeworks(self, start: date, end: date) -> list[HomeworkModel]:
|
||||
"""
|
||||
Récupère les devoirs via pronotepy.
|
||||
Les erreurs sont propagées pour déclencher le repli.
|
||||
"""
|
||||
client = self._get_client()
|
||||
return [HomeworkModel(
|
||||
id=str(hw.id),
|
||||
subject=hw.subject,
|
||||
teachers=[t.name for t in hw.teachers],
|
||||
assigned_on=hw.given_date,
|
||||
due_on=hw.due_date,
|
||||
text=hw.description,
|
||||
html=hw.description,
|
||||
) for hw in client.homework(start, end)]
|
||||
|
||||
def close(self) -> None:
|
||||
"""Fermeture du client."""
|
||||
@@ -2250,16 +2251,10 @@ class PronoteClient:
|
||||
|
||||
```python
|
||||
from typing import Literal, Optional
|
||||
from enum import Enum
|
||||
from enum import StrEnum
|
||||
from .ical import fetch_ical, parse_ical
|
||||
from .client import PronoteClient
|
||||
from ..models.agenda import Lesson, Homework
|
||||
|
||||
|
||||
class AgendaSource(Enum):
|
||||
AUTO = "auto"
|
||||
ICAL = "ical"
|
||||
PRONOTEPY = "pronotepy"
|
||||
from ..models.agenda import Lesson, SchoolEvent
|
||||
|
||||
|
||||
class PronoteFetcher:
|
||||
@@ -2271,6 +2266,8 @@ class PronoteFetcher:
|
||||
username: Optional[str] = None,
|
||||
password: Optional[str] = None,
|
||||
ent: Optional[str] = None,
|
||||
pronote_url: Optional[str] = None,
|
||||
account_type: str = "parent",
|
||||
agenda_source: str = "auto",
|
||||
homework_source: str = "auto",
|
||||
):
|
||||
@@ -2278,6 +2275,8 @@ class PronoteFetcher:
|
||||
self.username = username
|
||||
self.password = password
|
||||
self.ent = ent
|
||||
self.pronote_url = pronote_url
|
||||
self.account_type = account_type
|
||||
self.agenda_source = AgendaSource(agenda_source)
|
||||
self.homework_source = AgendaSource(homework_source)
|
||||
self._pronote_client: Optional[PronoteClient] = None
|
||||
@@ -2289,19 +2288,25 @@ class PronoteFetcher:
|
||||
password=self.password,
|
||||
ent=self.ent,
|
||||
ical_url=self.ical_url,
|
||||
pronote_url=self.pronote_url,
|
||||
account_type=self.account_type,
|
||||
)
|
||||
return self._pronote_client
|
||||
|
||||
def fetch_agenda(self) -> tuple[List[Lesson], List[Homework]]:
|
||||
"""Récupère l'agenda selon la source configurée (`agenda_source`)."""
|
||||
def fetch_agenda(self, start: date, end: date) -> tuple[list[Lesson], list[SchoolEvent]]:
|
||||
"""
|
||||
Récupère l'agenda selon la source configurée (`agenda_source`).
|
||||
En mode AUTO, essaie iCal d'abord, puis pronotepy. Si les deux échouent, lève une erreur explicite.
|
||||
"""
|
||||
from datetime import date
|
||||
if self.agenda_source == AgendaSource.ICAL:
|
||||
return self._fetch_agenda_ical()
|
||||
return self._fetch_agenda_ical(start, end)
|
||||
elif self.agenda_source == AgendaSource.PRONOTEPY:
|
||||
return self._fetch_agenda_pronotepy()
|
||||
return self._fetch_agenda_pronotepy(start, end)
|
||||
else: # AUTO
|
||||
# Essayer iCal d'abord
|
||||
try:
|
||||
lessons, homeworks = self._fetch_agenda_ical()
|
||||
lessons, homeworks = self._fetch_agenda_ical(start, end)
|
||||
if lessons or homeworks:
|
||||
return lessons, homeworks
|
||||
except Exception as e:
|
||||
@@ -2309,30 +2314,33 @@ class PronoteFetcher:
|
||||
|
||||
# Repli sur pronotepy
|
||||
logger.info("Repli sur pronotepy pour l'agenda.")
|
||||
return self._fetch_agenda_pronotepy()
|
||||
return self._fetch_agenda_pronotepy(start, end)
|
||||
|
||||
def fetch_homework(self) -> List[Homework]:
|
||||
"""Récupère les devoirs selon la source configurée (`homework_source`)."""
|
||||
def fetch_homework(self, start: date, end: date) -> list[SchoolEvent]:
|
||||
"""
|
||||
Récupère les devoirs selon la source configurée (`homework_source`).
|
||||
En mode AUTO, essaie iCal d'abord, puis pronotepy. Si les deux échouent, lève une erreur explicite.
|
||||
"""
|
||||
from datetime import date
|
||||
if self.homework_source == AgendaSource.ICAL:
|
||||
# Récupérer uniquement les devoirs depuis iCal
|
||||
try:
|
||||
_, homeworks = self._fetch_agenda_ical()
|
||||
_, homeworks = self._fetch_agenda_ical(start, end)
|
||||
return homeworks
|
||||
except Exception as e:
|
||||
logger.warning(f"Échec de la récupération iCal pour les devoirs: {redact_secrets(str(e))}")
|
||||
return []
|
||||
raise
|
||||
elif self.homework_source == AgendaSource.PRONOTEPY:
|
||||
# Récupérer uniquement les devoirs depuis pronotepy
|
||||
try:
|
||||
_, homeworks = self._fetch_agenda_pronotepy()
|
||||
return homeworks
|
||||
return self._fetch_agenda_pronotepy(start, end)[1]
|
||||
except Exception as e:
|
||||
logger.warning(f"Échec de la récupération pronotepy pour les devoirs: {redact_secrets(str(e))}")
|
||||
return []
|
||||
raise
|
||||
else: # AUTO
|
||||
# Essayer iCal d'abord
|
||||
try:
|
||||
_, homeworks = self._fetch_agenda_ical()
|
||||
_, homeworks = self._fetch_agenda_ical(start, end)
|
||||
if homeworks:
|
||||
return homeworks
|
||||
except Exception as e:
|
||||
@@ -2341,33 +2349,32 @@ class PronoteFetcher:
|
||||
# Repli sur pronotepy
|
||||
logger.info("Repli sur pronotepy pour les devoirs.")
|
||||
try:
|
||||
_, homeworks = self._fetch_agenda_pronotepy()
|
||||
return homeworks
|
||||
return self._fetch_agenda_pronotepy(start, end)[1]
|
||||
except Exception as e:
|
||||
logger.warning(f"Échec de la récupération pronotepy pour les devoirs: {redact_secrets(str(e))}")
|
||||
return []
|
||||
raise
|
||||
|
||||
def _fetch_agenda_ical(self) -> tuple[List[Lesson], List[Homework]]:
|
||||
def _fetch_agenda_ical(self, start: date, end: date) -> tuple[list[Lesson], list[SchoolEvent]]:
|
||||
"""Récupère l'agenda depuis iCal."""
|
||||
if not self.ical_url:
|
||||
raise ValueError("PRONOTE_ICAL_URL est requis pour la source iCal")
|
||||
|
||||
raw_ical = fetch_ical(self.ical_url)
|
||||
lessons, homeworks, _ = parse_ical(raw_ical)
|
||||
lessons, homeworks, _ = parse_ical(raw_ical, start, end)
|
||||
return lessons, homeworks
|
||||
|
||||
def _fetch_agenda_pronotepy(self) -> tuple[List[Lesson], List[Homework]]:
|
||||
def _fetch_agenda_pronotepy(self, start: date, end: date) -> tuple[list[Lesson], list[SchoolEvent]]:
|
||||
"""Récupère l'agenda depuis pronotepy."""
|
||||
client = self._get_pronote_client()
|
||||
lessons, homeworks = client.get_agenda_fallback()
|
||||
return lessons, homeworks
|
||||
lessons = client.get_lessons(start, end)
|
||||
return lessons, []
|
||||
|
||||
def fetch_messages(self) -> List[Message]:
|
||||
def fetch_messages(self) -> list[Message]:
|
||||
"""Récupère les messages (toujours via pronotepy)."""
|
||||
client = self._get_pronote_client()
|
||||
return client.get_messages()
|
||||
|
||||
def fetch_informations(self) -> List[Message]:
|
||||
def fetch_informations(self) -> list[Message]:
|
||||
"""Récupère les informations (toujours via pronotepy)."""
|
||||
client = self._get_pronote_client()
|
||||
return client.get_informations()
|
||||
@@ -5347,7 +5354,7 @@ def test_parse_ical_homework(parsed_lessons):
|
||||
def test_pipeline_full(mock_requests_get, mock_caldav_client, mock_ai_provider, mock_xmpp_channel, sample_settings):
|
||||
"""Test le pipeline complet avec des mocks."""
|
||||
from pronote_sync.pipeline.run import PipelineRunner
|
||||
from pronote_sync.sources.pronote.fetcher import PronoteFetcher
|
||||
from pronote_sync.sources.pronote.fallback import PronoteFetcher
|
||||
from pronote_sync.sync.caldav import CalDAVClient
|
||||
from pronote_sync.sync.diff import AgendaComparator
|
||||
from pronote_sync.sources.theoretical.file import CSVTheoreticalAgendaProvider
|
||||
|
||||
14
TODO.md
14
TODO.md
@@ -73,13 +73,13 @@ Définir tous les modèles de domaine, immuables pour les contrats, mutables pou
|
||||
|
||||
Récupérer et normaliser l'agenda, les devoirs et les messages Pronote, avec repli entre iCal et pronotepy.
|
||||
|
||||
- [ ] Créer `sources/pronote/ical.py` : `fetch_ical(url)` (HTTP via `requests`, erreurs redactées) et parsing iCal → `Lesson`/`Homework`/`SchoolEvent` (`icalendar`).
|
||||
- [ ] Extraire les blocs de devoirs (`HomeworkBlock`) depuis `DESCRIPTION` et dédupliquer les devoirs (clé normalisée par date).
|
||||
- [ ] Détecter les statuts (`CANCELLED`/`MOVED`) via `CATEGORIES` et `STATUS:CANCELLED`.
|
||||
- [ ] Créer `sources/pronote/client.py` : client `pronotepy` (messages, informations, discussions, sondages, et devoirs en repli) avec masquage des erreurs.
|
||||
- [ ] Créer `sources/pronote/fallback.py` : sélection de source selon `PRONOTE_*_SOURCE` (auto/ical/pronotepy) et `PronoteFetcher` unifiant `fetch_agenda`/`fetch_homework`/`fetch_messages`.
|
||||
- [ ] Implémenter le repli : iCal échoue → pronotepy ; pronotepy échoue → iCal ; les deux échouent → `PipelineCriticalError`.
|
||||
- [ ] Normaliser les UID via `utils/uid.normalize_pronote_uid` pour la stabilité des événements.
|
||||
- [x] Créer `sources/pronote/ical.py` : `fetch_ical(url)` (HTTP via `requests`, erreurs redactées) et parsing iCal → `Lesson`/`Homework`/`SchoolEvent` (`icalendar`).
|
||||
- [x] Extraire les blocs de devoirs (`HomeworkBlock`) depuis `DESCRIPTION` et dédupliquer les devoirs (clé normalisée par date).
|
||||
- [x] Détecter les statuts (`CANCELLED`/`MOVED`) via `CATEGORIES` et `STATUS:CANCELLED`.
|
||||
- [x] Créer `sources/pronote/client.py` : client `pronotepy` (messages, informations, discussions, sondages, et devoirs en repli) avec masquage des erreurs.
|
||||
- [x] Créer `sources/pronote/fallback.py` : sélection de source selon `PRONOTE_*_SOURCE` (auto/ical/pronotepy) et `PronoteFetcher` unifiant `fetch_agenda`/`fetch_homework`/`fetch_messages`.
|
||||
- [x] Implémenter le repli unique : source primaire + un seul repli (l'autre source si configurée) ; les deux échouent → `PipelineCriticalError`.
|
||||
- [x] Normaliser les UID via `utils/uid.normalize_pronote_uid` pour la stabilité des événements.
|
||||
|
||||
### Critères d'acceptation
|
||||
- `fetch_ical` parse `tests/fixtures/pronote-4e.ics` en leçons/devoirs/événements corrects (cours annulé détecté).
|
||||
|
||||
@@ -27,6 +27,8 @@ class PronoteSettings(BaseSettings):
|
||||
username: str | None = None
|
||||
password: SecretStr | None = None
|
||||
ent: str | None = None
|
||||
pronote_url: str | None = None
|
||||
account_type: Literal["student", "parent"] = "parent"
|
||||
agenda_source: Literal["auto", "ical", "pronotepy"] = "auto"
|
||||
homework_source: Literal["auto", "ical", "pronotepy"] = "auto"
|
||||
messages_source: Literal["pronotepy"] = "pronotepy"
|
||||
|
||||
@@ -3,16 +3,20 @@
|
||||
Ce module fournit l'encapsulation du client ``pronotepy`` pour la source
|
||||
Pronote : récupération des messages des professeurs, des informations et
|
||||
sondages, ainsi que des cours et devoirs en mode repli lorsque le flux
|
||||
iCal échoue. Toutes les erreurs sont journalisées avec des secrets masqués.
|
||||
iCal échoue. Les erreurs des méthodes dégradées (messages, informations)
|
||||
sont journalisées avec des secrets masqués ; les erreurs de récupération
|
||||
des cours et des devoirs se propagent pour déclencher le repli iCal.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import logging
|
||||
from datetime import date
|
||||
from typing import Protocol
|
||||
from typing import Any, Protocol
|
||||
|
||||
import pronotepy
|
||||
import pronotepy.ent as pronotepy_ent
|
||||
import requests
|
||||
|
||||
from pronote_sync.config.settings import PronoteSettings
|
||||
from pronote_sync.models.agenda import Lesson, LessonStatus
|
||||
@@ -23,6 +27,69 @@ from pronote_sync.utils.redaction import redact_exception
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
|
||||
def _get_ent_callable(name: str) -> Any:
|
||||
"""Retourne le callable ``pronotepy`` associé à un nom d'ENT.
|
||||
|
||||
L'accès par :func:`getattr` évite les erreurs ``attr-defined`` de mypy
|
||||
sur les attributs non exportés explicitement par ``pronotepy.ent``.
|
||||
|
||||
:param name: Nom de l'attribut dans ``pronotepy.ent``.
|
||||
:return: Callable ``pronotepy`` associé.
|
||||
:rtype: Any
|
||||
"""
|
||||
return getattr(pronotepy_ent, name)
|
||||
|
||||
|
||||
_ENT_NAMES: list[str] = [
|
||||
"monbureaunumerique",
|
||||
"ent_elyco",
|
||||
"bordeaux",
|
||||
"ent_creuse",
|
||||
"occitanie_montpellier",
|
||||
"paris_classe_numerique",
|
||||
"ile_de_france",
|
||||
"ent_hdf",
|
||||
"ac_orleans_tours",
|
||||
"ac_poitiers",
|
||||
"ac_rennes",
|
||||
"laclasse_educonnect",
|
||||
"ent77",
|
||||
"ent_ecollege78",
|
||||
"ent_essonne",
|
||||
"val_doise",
|
||||
"val_de_marne",
|
||||
"ent_var",
|
||||
"atrium_sud",
|
||||
"laclasse_lyon",
|
||||
"eclat_bfc",
|
||||
"cas_arsene76",
|
||||
"cas_ent27",
|
||||
"cas_kosmos",
|
||||
"ent_creuse_educonnect",
|
||||
"ent_mayotte",
|
||||
"ent_somme",
|
||||
"ent_94",
|
||||
"extranet_colleges_somme",
|
||||
"ac_reunion",
|
||||
]
|
||||
|
||||
_ENT_RESOLVERS: dict[str, Any] = {name: _get_ent_callable(name) for name in _ENT_NAMES}
|
||||
|
||||
|
||||
def _resolve_ent(ent_name: str) -> Any:
|
||||
"""Résout un nom d'ENT en callable ``pronotepy``.
|
||||
|
||||
:param ent_name: Nom de l'ENT tel que configuré (ex. ``"bordeaux"``).
|
||||
:return: Callable ``pronotepy`` associé à l'ENT.
|
||||
:raises ValueError: Si le nom d'ENT n'est pas reconnu.
|
||||
"""
|
||||
resolver = _ENT_RESOLVERS.get(ent_name)
|
||||
if resolver is None:
|
||||
supported = ", ".join(sorted(_ENT_RESOLVERS.keys()))
|
||||
raise ValueError(f"ENT inconnu : {ent_name!r}. ENT supportés : {supported}")
|
||||
return resolver
|
||||
|
||||
|
||||
class PronoteClientProtocol(Protocol):
|
||||
"""Interface du client Pronote consommée par la logique de repli."""
|
||||
|
||||
@@ -42,13 +109,23 @@ class PronoteClientProtocol(Protocol):
|
||||
"""
|
||||
...
|
||||
|
||||
def get_agenda_fallback(self, start: date, end: date) -> tuple[list[Lesson], list[Homework]]:
|
||||
"""Récupère les cours et les devoirs via ``pronotepy`` (repli iCal).
|
||||
def get_lessons(self, start: date, end: date) -> list[Lesson]:
|
||||
"""Récupère les cours via ``pronotepy`` (repli iCal).
|
||||
|
||||
:param start: Date de début de la fenêtre (incluse).
|
||||
:param end: Date de fin de la fenêtre (incluse).
|
||||
:return: Tuple ``(cours, devoirs)``.
|
||||
:rtype: tuple[list[Lesson], list[Homework]]
|
||||
:return: Liste des cours.
|
||||
:rtype: list[Lesson]
|
||||
"""
|
||||
...
|
||||
|
||||
def get_homeworks(self, start: date, end: date) -> list[Homework]:
|
||||
"""Récupère les devoirs via ``pronotepy``.
|
||||
|
||||
:param start: Date de début de la fenêtre (incluse).
|
||||
:param end: Date de fin de la fenêtre (incluse).
|
||||
:return: Liste des devoirs.
|
||||
:rtype: list[Homework]
|
||||
"""
|
||||
...
|
||||
|
||||
@@ -56,11 +133,13 @@ class PronoteClientProtocol(Protocol):
|
||||
class PronoteClient:
|
||||
"""Client d'accès à Pronote via ``pronotepy``.
|
||||
|
||||
Encapsule ``pronotepy.Client`` avec une connexion paresseuse : la
|
||||
connexion n'est établie qu'à la première méthode de récupération
|
||||
appelée. Les erreurs ``pronotepy.PronoteAPIError`` sont journalisées
|
||||
avec des secrets masqués et les méthodes de récupération retournent
|
||||
alors une valeur vide au lieu de propager l'exception.
|
||||
Encapsule ``pronotepy.Client`` ou ``pronotepy.ParentClient`` selon le
|
||||
type de compte, avec une connexion paresseuse : la connexion n'est
|
||||
établie qu'à la première méthode de récupération appelée. Les erreurs
|
||||
des méthodes dégradées (``get_messages()``, ``get_informations()``)
|
||||
sont journalisées avec des secrets masqués et retournent une valeur
|
||||
vide ; ``get_lessons()`` et ``get_homeworks()`` laissent les
|
||||
exceptions se propager pour déclencher le repli iCal.
|
||||
"""
|
||||
|
||||
def __init__(self, settings: PronoteSettings) -> None:
|
||||
@@ -75,24 +154,39 @@ class PronoteClient:
|
||||
"""Crée et connecte le client ``pronotepy`` (connexion paresseuse).
|
||||
|
||||
Le client est créé une seule fois puis réutilisé pour les appels
|
||||
suivants. L'erreur de connexion est relancée sans journalisation,
|
||||
la méthode publique appelante étant responsable de la journaliser.
|
||||
suivants. Le nom d'ENT est résolu via :func:`_resolve_ent` et le
|
||||
type de compte (``student`` ou ``parent``) détermine la classe de
|
||||
client utilisée. L'erreur de connexion est relancée sans
|
||||
journalisation, la méthode publique appelante étant responsable
|
||||
de la journaliser.
|
||||
|
||||
:return: Le client ``pronotepy`` connecté.
|
||||
:rtype: pronotepy.Client
|
||||
:raises ValueError: Si ``username``, ``password`` ou ``ent`` est manquant.
|
||||
:raises ValueError: Si ``pronote_url``, ``username``, ``password``
|
||||
ou ``ent`` est manquant, ou si l'ENT est inconnu.
|
||||
:raises pronotepy.PronoteAPIError: Si la connexion à Pronote échoue.
|
||||
"""
|
||||
if self._client is None:
|
||||
pronote_url = self._settings.pronote_url
|
||||
username = self._settings.username
|
||||
password = self._settings.password
|
||||
ent = self._settings.ent
|
||||
if username is None or password is None or ent is None:
|
||||
raise ValueError("username, password et ent sont requis pour pronotepy")
|
||||
try:
|
||||
self._client = pronotepy.Client(username, password.get_secret_value(), ent)
|
||||
except pronotepy.PronoteAPIError:
|
||||
raise
|
||||
if pronote_url is None or username is None or password is None or ent is None:
|
||||
raise ValueError(
|
||||
"pronote_url, username, password et ent sont requis pour pronotepy"
|
||||
)
|
||||
resolver = _resolve_ent(ent)
|
||||
client_class: type[pronotepy.Client] = (
|
||||
pronotepy.ParentClient
|
||||
if self._settings.account_type == "parent"
|
||||
else pronotepy.Client
|
||||
)
|
||||
self._client = client_class(
|
||||
pronote_url=pronote_url,
|
||||
username=username,
|
||||
password=password.get_secret_value(),
|
||||
ent=resolver,
|
||||
)
|
||||
return self._client
|
||||
|
||||
def get_messages(self) -> list[Message]:
|
||||
@@ -122,7 +216,13 @@ class PronoteClient:
|
||||
)
|
||||
)
|
||||
return messages
|
||||
except (pronotepy.PronoteAPIError, ValueError) as exc:
|
||||
except (
|
||||
pronotepy.PronoteAPIError,
|
||||
ValueError,
|
||||
requests.RequestException,
|
||||
ConnectionError,
|
||||
TimeoutError,
|
||||
) as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération des messages Pronote : %s",
|
||||
redact_exception(exc),
|
||||
@@ -154,62 +254,86 @@ class PronoteClient:
|
||||
)
|
||||
)
|
||||
return messages
|
||||
except (pronotepy.PronoteAPIError, ValueError) as exc:
|
||||
except (
|
||||
pronotepy.PronoteAPIError,
|
||||
ValueError,
|
||||
requests.RequestException,
|
||||
ConnectionError,
|
||||
TimeoutError,
|
||||
) as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération des informations Pronote : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
return []
|
||||
|
||||
def get_agenda_fallback(self, start: date, end: date) -> tuple[list[Lesson], list[Homework]]:
|
||||
"""Récupère les cours et les devoirs via ``pronotepy``.
|
||||
def get_lessons(self, start: date, end: date) -> list[Lesson]:
|
||||
"""Récupère les cours via ``pronotepy`` (repli iCal).
|
||||
|
||||
À utiliser uniquement si les sources iCal sont indisponibles ou en
|
||||
repli automatique. Les cours annulés sont mappés sur le statut
|
||||
``CANCELLED`` ; **pronotepy** ne fournissant ni la date de
|
||||
Les exceptions ne sont pas attrapées : elles se propagent afin que
|
||||
l'appelant puisse détecter l'échec et déclencher le repli (ou une
|
||||
erreur explicite).
|
||||
|
||||
:param start: Date de début de la fenêtre (incluse).
|
||||
:param end: Date de fin de la fenêtre (incluse).
|
||||
:return: Liste des cours.
|
||||
:rtype: list[Lesson]
|
||||
:raises pronotepy.PronoteAPIError: Si l'API Pronote échoue.
|
||||
:raises ValueError: Si la configuration ou l'ENT est invalide.
|
||||
:raises requests.RequestException: Si une requête réseau échoue.
|
||||
:raises ConnectionError: Si la connexion réseau échoue.
|
||||
:raises TimeoutError: Si la requête réseau expire.
|
||||
"""
|
||||
client = self._connect()
|
||||
lessons: list[Lesson] = []
|
||||
for lesson in client.lessons(start, end):
|
||||
content = lesson.content
|
||||
lessons.append(
|
||||
Lesson(
|
||||
id=lesson.id,
|
||||
start=lesson.start,
|
||||
end=lesson.end,
|
||||
subject=lesson.subject.name if lesson.subject is not None else "",
|
||||
teachers=tuple(lesson.teacher_names or ()),
|
||||
rooms=tuple(lesson.classrooms or ()),
|
||||
group=lesson.group_name,
|
||||
status=(LessonStatus.CANCELLED if lesson.canceled else LessonStatus.NORMAL),
|
||||
content=content.description if content is not None else None,
|
||||
)
|
||||
)
|
||||
return lessons
|
||||
|
||||
def get_homeworks(self, start: date, end: date) -> list[Homework]:
|
||||
"""Récupère les devoirs via ``pronotepy``.
|
||||
|
||||
Les exceptions ne sont pas attrapées : elles se propagent afin que
|
||||
l'appelant puisse détecter l'échec et déclencher le repli (ou une
|
||||
erreur explicite). **pronotepy** ne fournissant ni la date de
|
||||
distribution ni les professeurs des devoirs, ces champs restent
|
||||
vides.
|
||||
|
||||
:param start: Date de début de la fenêtre (incluse).
|
||||
:param end: Date de fin de la fenêtre (incluse).
|
||||
:return: Tuple ``(cours, devoirs)`` ; vide en cas d'erreur.
|
||||
:rtype: tuple[list[Lesson], list[Homework]]
|
||||
:return: Liste des devoirs.
|
||||
:rtype: list[Homework]
|
||||
:raises pronotepy.PronoteAPIError: Si l'API Pronote échoue.
|
||||
:raises ValueError: Si la configuration ou l'ENT est invalide.
|
||||
:raises requests.RequestException: Si une requête réseau échoue.
|
||||
:raises ConnectionError: Si la connexion réseau échoue.
|
||||
:raises TimeoutError: Si la requête réseau expire.
|
||||
"""
|
||||
try:
|
||||
client = self._connect()
|
||||
lessons: list[Lesson] = []
|
||||
for lesson in client.lessons(start, end):
|
||||
content = lesson.content
|
||||
lessons.append(
|
||||
Lesson(
|
||||
id=lesson.id,
|
||||
start=lesson.start,
|
||||
end=lesson.end,
|
||||
subject=lesson.subject.name if lesson.subject is not None else "",
|
||||
teachers=tuple(lesson.teacher_names or ()),
|
||||
rooms=tuple(lesson.classrooms or ()),
|
||||
group=lesson.group_name,
|
||||
status=(LessonStatus.CANCELLED if lesson.canceled else LessonStatus.NORMAL),
|
||||
content=content.description if content is not None else None,
|
||||
)
|
||||
client = self._connect()
|
||||
homeworks: list[Homework] = []
|
||||
for hw in client.homework(start, end):
|
||||
homeworks.append(
|
||||
Homework(
|
||||
id=hw.id,
|
||||
subject=hw.subject.name,
|
||||
teachers=(),
|
||||
assigned_on=None,
|
||||
due_on=hw.date,
|
||||
text=hw.description,
|
||||
html=hw.description,
|
||||
)
|
||||
homeworks: list[Homework] = []
|
||||
for hw in client.homework(start, end):
|
||||
homeworks.append(
|
||||
Homework(
|
||||
id=hw.id,
|
||||
subject=hw.subject.name,
|
||||
teachers=(),
|
||||
assigned_on=None,
|
||||
due_on=hw.date,
|
||||
text=hw.description,
|
||||
html=hw.description,
|
||||
)
|
||||
)
|
||||
return lessons, homeworks
|
||||
except (pronotepy.PronoteAPIError, ValueError) as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération de l'agenda via pronotepy : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
return [], []
|
||||
return homeworks
|
||||
|
||||
@@ -3,11 +3,14 @@
|
||||
Ce module fournit l'enum :class:`AgendaSource`, le protocole
|
||||
:class:`PronoteFetcherProtocol` consommé par le pipeline ainsi que la
|
||||
classe :class:`PronoteFetcher` qui sélectionne la source selon la
|
||||
configuration (``PRONOTE_AGENDA_SOURCE`` / ``PRONOTE_HOMEWORK_SOURCE``)
|
||||
avec repli automatique iCal → pronotepy en mode ``auto``. Les messages
|
||||
configuration (``PRONOTE_AGENDA_SOURCE`` / ``PRONOTE_HOMEWORK_SOURCE``).
|
||||
La logique applique un repli **unique** : une source primaire est
|
||||
essayée en premier et, en cas d'échec, une seule source de repli (jamais
|
||||
réciproque ni itératif) est essayée si elle est configurée. Les messages
|
||||
et informations proviennent toujours de pronotepy. Toutes les erreurs
|
||||
sont journalisées avec des secrets masqués via
|
||||
:func:`~pronote_sync.utils.redaction.redact_exception`.
|
||||
:func:`~pronote_sync.utils.redaction.redact_exception` ; les exceptions
|
||||
d'origine ne sont jamais chaînées (``from None``).
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
@@ -15,7 +18,7 @@ from __future__ import annotations
|
||||
import logging
|
||||
from datetime import date, timedelta
|
||||
from enum import StrEnum
|
||||
from typing import Protocol
|
||||
from typing import Literal, Protocol
|
||||
|
||||
from pronote_sync.config.settings import Settings
|
||||
from pronote_sync.errors import PipelineCriticalError
|
||||
@@ -28,6 +31,8 @@ from pronote_sync.utils.redaction import redact_exception
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
_SourceName = Literal["ical", "pronotepy"]
|
||||
|
||||
|
||||
class AgendaSource(StrEnum):
|
||||
"""Source configurée pour la récupération de l'agenda et des devoirs."""
|
||||
@@ -77,12 +82,13 @@ class PronoteFetcherProtocol(Protocol):
|
||||
|
||||
|
||||
class PronoteFetcher:
|
||||
"""Récupère les données Pronote via iCal ou pronotepy avec repli.
|
||||
"""Récupère les données Pronote via iCal ou pronotepy avec repli unique.
|
||||
|
||||
Unifie les sources iCal et pronotepy selon la source configurée
|
||||
(``agenda_source`` / ``homework_source``) : en mode ``AUTO``, le flux
|
||||
iCal est essayé en premier et pronotepy sert de repli. Les messages et
|
||||
informations proviennent toujours de pronotepy.
|
||||
(``agenda_source`` / ``homework_source``) : la source primaire est
|
||||
essayée en premier et, si elle échoue, une seule source de repli est
|
||||
essayée lorsqu'elle est configurée. Les messages et informations
|
||||
proviennent toujours de pronotepy.
|
||||
"""
|
||||
|
||||
def __init__(self, settings: Settings, pronote_client: PronoteClientProtocol) -> None:
|
||||
@@ -105,6 +111,29 @@ class PronoteFetcher:
|
||||
end = today + timedelta(days=self._settings.app.sync_future_days)
|
||||
return start, end
|
||||
|
||||
def _is_ical_configured(self) -> bool:
|
||||
"""Vérifie que la source iCal est configurée.
|
||||
|
||||
:return: ``True`` si ``ical_url`` est défini, ``False`` sinon.
|
||||
:rtype: bool
|
||||
"""
|
||||
return self._settings.pronote.ical_url is not None
|
||||
|
||||
def _is_pronotepy_configured(self) -> bool:
|
||||
"""Vérifie que la source pronotepy est entièrement configurée.
|
||||
|
||||
:return: ``True`` si ``pronote_url``, ``username``, ``password``
|
||||
et ``ent`` sont tous définis, ``False`` sinon.
|
||||
:rtype: bool
|
||||
"""
|
||||
pronote = self._settings.pronote
|
||||
return (
|
||||
pronote.pronote_url is not None
|
||||
and pronote.username is not None
|
||||
and pronote.password is not None
|
||||
and pronote.ent is not None
|
||||
)
|
||||
|
||||
def _fetch_agenda_ical(self) -> tuple[list[Lesson], list[SchoolEvent]]:
|
||||
"""Récupère l'agenda depuis le flux iCal.
|
||||
|
||||
@@ -129,70 +158,101 @@ class PronoteFetcher:
|
||||
|
||||
:return: Tuple ``(cours, événements scolaires)``.
|
||||
:rtype: tuple[list[Lesson], list[SchoolEvent]]
|
||||
:raises pronotepy.PronoteAPIError: Si l'API Pronote échoue.
|
||||
:raises ValueError: Si la configuration ou l'ENT est invalide.
|
||||
:raises requests.RequestException: Si une requête réseau échoue.
|
||||
:raises ConnectionError: Si la connexion réseau échoue.
|
||||
:raises TimeoutError: Si la requête réseau expire.
|
||||
"""
|
||||
start, end = self._fetch_window()
|
||||
lessons, _ = self._pronote_client.get_agenda_fallback(start, end)
|
||||
lessons = self._pronote_client.get_lessons(start, end)
|
||||
return lessons, []
|
||||
|
||||
def _agenda_sources(self) -> tuple[_SourceName, _SourceName | None]:
|
||||
"""Sélectionne la source primaire et le repli unique pour l'agenda.
|
||||
|
||||
En mode ``AUTO``, iCal est primaire si ``ical_url`` est configuré
|
||||
(repli pronotepy si la configuration pronotepy est complète),
|
||||
sinon pronotepy sans repli. Les modes explicites ``ICAL`` et
|
||||
``PRONOTEPY`` désignent la source primaire et tentent l'autre
|
||||
source en repli unique si elle est configurée.
|
||||
|
||||
:return: Tuple ``(source primaire, source de repli ou ``None``)``.
|
||||
:rtype: tuple[_SourceName, _SourceName | None]
|
||||
:raises PipelineCriticalError: Si aucune source n'est configurée en mode ``AUTO``.
|
||||
"""
|
||||
source = AgendaSource(self._settings.pronote.agenda_source)
|
||||
if source is AgendaSource.ICAL:
|
||||
return "ical", "pronotepy" if self._is_pronotepy_configured() else None
|
||||
if source is AgendaSource.PRONOTEPY:
|
||||
return "pronotepy", "ical" if self._is_ical_configured() else None
|
||||
if self._is_ical_configured():
|
||||
return "ical", "pronotepy" if self._is_pronotepy_configured() else None
|
||||
if self._is_pronotepy_configured():
|
||||
return "pronotepy", None
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer l'agenda : ni la source iCal ni pronotepy n'est configurée"
|
||||
) from None
|
||||
|
||||
def _fetch_agenda_source(self, name: _SourceName) -> tuple[list[Lesson], list[SchoolEvent]]:
|
||||
"""Récupère l'agenda depuis la source nommée.
|
||||
|
||||
:param name: Nom de la source (``"ical"`` ou ``"pronotepy"``).
|
||||
:return: Tuple ``(cours, événements scolaires)``.
|
||||
:rtype: tuple[list[Lesson], list[SchoolEvent]]
|
||||
"""
|
||||
if name == "ical":
|
||||
return self._fetch_agenda_ical()
|
||||
return self._fetch_agenda_pronotepy()
|
||||
|
||||
def fetch_agenda(self) -> tuple[list[Lesson], list[SchoolEvent]]:
|
||||
"""Récupère les cours et les événements scolaires selon la source configurée.
|
||||
|
||||
En mode ``AUTO``, iCal est essayé en premier et pronotepy sert de
|
||||
repli ; si les deux sources échouent, une erreur critique est levée.
|
||||
La source primaire est essayée en premier ; si elle échoue, la
|
||||
source de repli unique (l'autre source, si configurée) est
|
||||
essayée. Si la source primaire et le repli échouent — ou si
|
||||
aucune source n'est configurée en mode ``AUTO`` — une erreur
|
||||
critique est levée.
|
||||
|
||||
:return: Tuple ``(cours, événements scolaires)``.
|
||||
:rtype: tuple[list[Lesson], list[SchoolEvent]]
|
||||
:raises PipelineCriticalError: Si toutes les sources configurées échouent.
|
||||
:raises PipelineCriticalError: Si toutes les sources tentées échouent.
|
||||
"""
|
||||
source = AgendaSource(self._settings.pronote.agenda_source)
|
||||
if source is AgendaSource.ICAL:
|
||||
try:
|
||||
return self._fetch_agenda_ical()
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération iCal pour l'agenda : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer l'agenda : la source iCal a échoué"
|
||||
) from exc
|
||||
if source is AgendaSource.PRONOTEPY:
|
||||
try:
|
||||
return self._fetch_agenda_pronotepy()
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération pronotepy pour l'agenda : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer l'agenda : la source pronotepy a échoué"
|
||||
) from exc
|
||||
|
||||
# Mode AUTO : essayer iCal d'abord, puis replier sur pronotepy.
|
||||
primary, fallback = self._agenda_sources()
|
||||
try:
|
||||
return self._fetch_agenda_ical()
|
||||
except Exception as exc:
|
||||
logger.warning(
|
||||
"Échec de la récupération iCal pour l'agenda : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
logger.info("Repli sur pronotepy pour l'agenda.")
|
||||
try:
|
||||
lessons, school_events = self._fetch_agenda_pronotepy()
|
||||
return self._fetch_agenda_source(primary)
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération pronotepy pour l'agenda : %s",
|
||||
"Échec de la récupération %s pour l'agenda : %s",
|
||||
primary,
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer l'agenda : les sources iCal et pronotepy ont échoué"
|
||||
) from exc
|
||||
if not lessons:
|
||||
logger.warning(
|
||||
"Le repli pronotepy pour l'agenda a retourné un résultat vide après l'échec "
|
||||
"d'iCal : impossible de distinguer une absence de cours d'un échec silencieux."
|
||||
)
|
||||
return lessons, school_events
|
||||
if fallback is None:
|
||||
raise PipelineCriticalError(
|
||||
f"Impossible de récupérer l'agenda : la source {primary} a échoué"
|
||||
) from None
|
||||
logger.info("Repli sur %s pour l'agenda.", fallback)
|
||||
try:
|
||||
lessons, school_events = self._fetch_agenda_source(fallback)
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération %s pour l'agenda : %s",
|
||||
fallback,
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
f"Impossible de récupérer l'agenda : les sources {primary}"
|
||||
f" et {fallback} ont échoué"
|
||||
) from None
|
||||
if not lessons:
|
||||
logger.warning(
|
||||
"Le repli %s pour l'agenda a retourné un résultat vide après l'échec "
|
||||
"de %s : impossible de distinguer une absence de cours d'un échec "
|
||||
"silencieux.",
|
||||
fallback,
|
||||
primary,
|
||||
)
|
||||
return lessons, school_events
|
||||
|
||||
def _fetch_homework_ical(self, target_date: date) -> list[Homework]:
|
||||
"""Récupère les devoirs depuis le flux iCal pour la date cible.
|
||||
@@ -207,76 +267,112 @@ class PronoteFetcher:
|
||||
lessons, _ = self._fetch_agenda_ical()
|
||||
return collect_homeworks(lessons, target_date)
|
||||
|
||||
def _fetch_homework_pronotepy(self) -> list[Homework]:
|
||||
"""Récupère les devoirs depuis pronotepy.
|
||||
def _fetch_homework_pronotepy(self, target_date: date) -> list[Homework]:
|
||||
"""Récupère les devoirs depuis pronotepy pour la date cible.
|
||||
|
||||
:return: Liste des devoirs.
|
||||
:rtype: list[Homework]
|
||||
"""
|
||||
start, end = self._fetch_window()
|
||||
_, homeworks = self._pronote_client.get_agenda_fallback(start, end)
|
||||
return homeworks
|
||||
|
||||
def fetch_homework(self, target_date: date) -> list[Homework]:
|
||||
"""Récupère les devoirs selon la source configurée.
|
||||
|
||||
En mode ``AUTO``, iCal est essayé en premier et pronotepy sert de
|
||||
repli ; si les deux sources échouent, une erreur critique est levée.
|
||||
Les devoirs sont filtrés sur la date d'échéance : seuls ceux dont
|
||||
``due_on`` correspond à ``target_date`` sont conservés.
|
||||
|
||||
:param target_date: Date cible pour laquelle collecter les devoirs.
|
||||
:return: Liste des devoirs.
|
||||
:rtype: list[Homework]
|
||||
:raises PipelineCriticalError: Si toutes les sources configurées échouent.
|
||||
:raises pronotepy.PronoteAPIError: Si l'API Pronote échoue.
|
||||
:raises ValueError: Si la configuration ou l'ENT est invalide.
|
||||
:raises requests.RequestException: Si une requête réseau échoue.
|
||||
:raises ConnectionError: Si la connexion réseau échoue.
|
||||
:raises TimeoutError: Si la requête réseau expire.
|
||||
"""
|
||||
start, end = self._fetch_window()
|
||||
homeworks = self._pronote_client.get_homeworks(start, end)
|
||||
return [hw for hw in homeworks if hw.due_on == target_date]
|
||||
|
||||
def _homework_sources(self) -> tuple[_SourceName, _SourceName | None]:
|
||||
"""Sélectionne la source primaire et le repli unique pour les devoirs.
|
||||
|
||||
En mode ``AUTO``, iCal est primaire si ``ical_url`` est configuré
|
||||
(repli pronotepy si la configuration pronotepy est complète),
|
||||
sinon pronotepy sans repli. Les modes explicites ``ICAL`` et
|
||||
``PRONOTEPY`` désignent la source primaire et tentent l'autre
|
||||
source en repli unique si elle est configurée.
|
||||
|
||||
:return: Tuple ``(source primaire, source de repli ou ``None``)``.
|
||||
:rtype: tuple[_SourceName, _SourceName | None]
|
||||
:raises PipelineCriticalError: Si aucune source n'est configurée en mode ``AUTO``.
|
||||
"""
|
||||
source = AgendaSource(self._settings.pronote.homework_source)
|
||||
if source is AgendaSource.ICAL:
|
||||
try:
|
||||
return self._fetch_homework_ical(target_date)
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération iCal pour les devoirs : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer les devoirs : la source iCal a échoué"
|
||||
) from exc
|
||||
return "ical", "pronotepy" if self._is_pronotepy_configured() else None
|
||||
if source is AgendaSource.PRONOTEPY:
|
||||
try:
|
||||
return self._fetch_homework_pronotepy()
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération pronotepy pour les devoirs : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer les devoirs : la source pronotepy a échoué"
|
||||
) from exc
|
||||
return "pronotepy", "ical" if self._is_ical_configured() else None
|
||||
if self._is_ical_configured():
|
||||
return "ical", "pronotepy" if self._is_pronotepy_configured() else None
|
||||
if self._is_pronotepy_configured():
|
||||
return "pronotepy", None
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer les devoirs : ni la source iCal ni pronotepy n'est configurée"
|
||||
) from None
|
||||
|
||||
# Mode AUTO : essayer iCal d'abord, puis replier sur pronotepy.
|
||||
try:
|
||||
def _fetch_homework_source(self, name: _SourceName, target_date: date) -> list[Homework]:
|
||||
"""Récupère les devoirs depuis la source nommée.
|
||||
|
||||
:param name: Nom de la source (``"ical"`` ou ``"pronotepy"``).
|
||||
:param target_date: Date cible pour laquelle collecter les devoirs.
|
||||
:return: Liste des devoirs.
|
||||
:rtype: list[Homework]
|
||||
"""
|
||||
if name == "ical":
|
||||
return self._fetch_homework_ical(target_date)
|
||||
except Exception as exc:
|
||||
logger.warning(
|
||||
"Échec de la récupération iCal pour les devoirs : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
logger.info("Repli sur pronotepy pour les devoirs.")
|
||||
return self._fetch_homework_pronotepy(target_date)
|
||||
|
||||
def fetch_homework(self, target_date: date) -> list[Homework]:
|
||||
"""Récupère les devoirs selon la source configurée.
|
||||
|
||||
La source primaire est essayée en premier ; si elle échoue, la
|
||||
source de repli unique (l'autre source, si configurée) est
|
||||
essayée. Si la source primaire et le repli échouent — ou si
|
||||
aucune source n'est configurée en mode ``AUTO`` — une erreur
|
||||
critique est levée.
|
||||
|
||||
:param target_date: Date cible pour laquelle collecter les devoirs.
|
||||
:return: Liste des devoirs.
|
||||
:rtype: list[Homework]
|
||||
:raises PipelineCriticalError: Si toutes les sources tentées échouent.
|
||||
"""
|
||||
primary, fallback = self._homework_sources()
|
||||
try:
|
||||
homeworks = self._fetch_homework_pronotepy()
|
||||
return self._fetch_homework_source(primary, target_date)
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération pronotepy pour les devoirs : %s",
|
||||
"Échec de la récupération %s pour les devoirs : %s",
|
||||
primary,
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
"Impossible de récupérer les devoirs : les sources iCal et pronotepy ont échoué"
|
||||
) from exc
|
||||
if not homeworks:
|
||||
logger.warning(
|
||||
"Le repli pronotepy pour les devoirs a retourné un résultat vide après l'échec "
|
||||
"d'iCal : impossible de distinguer une absence de devoirs d'un échec silencieux."
|
||||
)
|
||||
return homeworks
|
||||
if fallback is None:
|
||||
raise PipelineCriticalError(
|
||||
f"Impossible de récupérer les devoirs : la source {primary} a échoué"
|
||||
) from None
|
||||
logger.info("Repli sur %s pour les devoirs.", fallback)
|
||||
try:
|
||||
homeworks = self._fetch_homework_source(fallback, target_date)
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération %s pour les devoirs : %s",
|
||||
fallback,
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise PipelineCriticalError(
|
||||
f"Impossible de récupérer les devoirs : les sources {primary}"
|
||||
f" et {fallback} ont échoué"
|
||||
) from None
|
||||
if not homeworks:
|
||||
logger.warning(
|
||||
"Le repli %s pour les devoirs a retourné un résultat vide après "
|
||||
"l'échec de %s : impossible de distinguer une absence de devoirs "
|
||||
"d'un échec silencieux.",
|
||||
fallback,
|
||||
primary,
|
||||
)
|
||||
return homeworks
|
||||
|
||||
def fetch_messages(self) -> list[Message]:
|
||||
"""Récupère les messages des discussions Pronote (toujours via pronotepy).
|
||||
@@ -284,7 +380,14 @@ class PronoteFetcher:
|
||||
:return: Liste des messages.
|
||||
:rtype: list[Message]
|
||||
"""
|
||||
return self._pronote_client.get_messages()
|
||||
try:
|
||||
return self._pronote_client.get_messages()
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération des messages : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise
|
||||
|
||||
def fetch_informations(self) -> list[Message]:
|
||||
"""Récupère les informations et sondages Pronote (toujours via pronotepy).
|
||||
@@ -292,4 +395,11 @@ class PronoteFetcher:
|
||||
:return: Liste des informations et sondages.
|
||||
:rtype: list[Message]
|
||||
"""
|
||||
return self._pronote_client.get_informations()
|
||||
try:
|
||||
return self._pronote_client.get_informations()
|
||||
except Exception as exc:
|
||||
logger.error(
|
||||
"Échec de la récupération des informations : %s",
|
||||
redact_exception(exc),
|
||||
)
|
||||
raise
|
||||
|
||||
@@ -218,21 +218,23 @@ def _parse_french_date(value: str) -> date | None:
|
||||
return None
|
||||
|
||||
|
||||
def parse_body(body: str) -> tuple[str | None, dict[date, str], dict[date, str]]:
|
||||
def parse_body(body: str) -> tuple[str | None, list[tuple[date, str]], list[tuple[date, str]]]:
|
||||
"""Parse le corps HTML pour extraire contenu pédagogique et devoirs.
|
||||
|
||||
Le contenu est extrait de la section ``<strong>Contenu pédagogique :</strong>``.
|
||||
Les devoirs à faire sont extraits des sections ``<strong>Pour le JJ/MM/AAAA :</strong>``
|
||||
(dict date → texte) et les devoirs donnés des sections
|
||||
``<strong>Donné le JJ/MM/AAAA :</strong>`` (dict date → texte).
|
||||
(liste de tuples ``(date, texte)`` dans l'ordre du flux) et les devoirs donnés
|
||||
des sections ``<strong>Donné le JJ/MM/AAAA :</strong>`` (liste de tuples
|
||||
``(date, texte)``). Les listes préservent tous les blocs, même lorsque plusieurs
|
||||
sections partagent la même date.
|
||||
|
||||
:param body: Corps HTML (à partir du premier ``<strong>``).
|
||||
:return: Tuple ``(contenu pédagogique, devoirs dus, devoirs donnés)``.
|
||||
:rtype: tuple[str | None, dict[date, str], dict[date, str]]
|
||||
:rtype: tuple[str | None, list[tuple[date, str]], list[tuple[date, str]]]
|
||||
"""
|
||||
content: str | None = None
|
||||
due_blocks: dict[date, str] = {}
|
||||
assigned_blocks: dict[date, str] = {}
|
||||
due_blocks: list[tuple[date, str]] = []
|
||||
assigned_blocks: list[tuple[date, str]] = []
|
||||
|
||||
content_match = _CONTENT_PATTERN.search(body)
|
||||
if content_match is not None:
|
||||
@@ -241,34 +243,35 @@ def parse_body(body: str) -> tuple[str | None, dict[date, str], dict[date, str]]
|
||||
for match in _DUE_PATTERN.finditer(body):
|
||||
due_date = _parse_french_date(match.group(1))
|
||||
if due_date is not None:
|
||||
due_blocks[due_date] = _strip_html(match.group(2))
|
||||
due_blocks.append((due_date, _strip_html(match.group(2))))
|
||||
|
||||
for match in _ASSIGNED_PATTERN.finditer(body):
|
||||
assigned_date = _parse_french_date(match.group(1))
|
||||
if assigned_date is not None:
|
||||
assigned_blocks[assigned_date] = _strip_html(match.group(2))
|
||||
assigned_blocks.append((assigned_date, _strip_html(match.group(2))))
|
||||
|
||||
return content, due_blocks, assigned_blocks
|
||||
|
||||
|
||||
def parse_homework_blocks(
|
||||
due_blocks: dict[date, str],
|
||||
assigned_blocks: dict[date, str],
|
||||
due_blocks: list[tuple[date, str]],
|
||||
assigned_blocks: list[tuple[date, str]],
|
||||
) -> tuple[HomeworkBlock, ...]:
|
||||
"""Construit les :class:`HomeworkBlock` depuis les dicts de devoirs.
|
||||
"""Construit les :class:`HomeworkBlock` depuis les listes de devoirs.
|
||||
|
||||
Les blocs dus (``kind="due"``) précèdent les blocs donnés
|
||||
(``kind="assigned"``), dans l'ordre d'insertion des dicts.
|
||||
(``kind="assigned"``), dans l'ordre des listes. Tous les blocs
|
||||
sont préservés, y compris lorsque plusieurs partagent la même date.
|
||||
|
||||
:param due_blocks: Dict date → texte des devoirs à faire.
|
||||
:param assigned_blocks: Dict date → texte des devoirs donnés.
|
||||
:param due_blocks: Liste de tuples ``(date, texte)`` des devoirs à faire.
|
||||
:param assigned_blocks: Liste de tuples ``(date, texte)`` des devoirs donnés.
|
||||
:return: Tuple de blocs de devoirs pour le cours.
|
||||
:rtype: tuple[HomeworkBlock, ...]
|
||||
"""
|
||||
blocks: list[HomeworkBlock] = []
|
||||
for due_date, text in due_blocks.items():
|
||||
for due_date, text in due_blocks:
|
||||
blocks.append(HomeworkBlock(kind="due", date=due_date, text=text, html=text))
|
||||
for assigned_date, text in assigned_blocks.items():
|
||||
for assigned_date, text in assigned_blocks:
|
||||
blocks.append(HomeworkBlock(kind="assigned", date=assigned_date, text=text, html=text))
|
||||
return tuple(blocks)
|
||||
|
||||
@@ -360,9 +363,10 @@ def parse_ical(raw_ical: str) -> tuple[list[Lesson], list[Homework], list[School
|
||||
|
||||
Les VEVENT de vacances/congés (tout le jour) deviennent des
|
||||
:class:`SchoolEvent` de type ``holiday``. Les VEVENT horodatés
|
||||
deviennent des :class:`Lesson` dont le statut dérive de la
|
||||
catégorie (``Cours - Cours annulé`` → ``CANCELLED``,
|
||||
``Cours - Cours déplacé`` → ``MOVED``). Les UID sont normalisés ;
|
||||
deviennent des :class:`Lesson` dont le statut dérive de la propriété
|
||||
``STATUS`` (``CANCELLED`` → ``CANCELLED``) et de la catégorie
|
||||
(``Cours - Cours annulé`` → ``CANCELLED``, ``Cours - Cours déplacé`` →
|
||||
``MOVED``). Les UID sont normalisés ;
|
||||
un événement sans UID reçoit un UID déterministe généré à partir
|
||||
de ses champs clés (début, fin, matière, enseignants, salles, groupe).
|
||||
|
||||
@@ -416,11 +420,14 @@ def parse_ical(raw_ical: str) -> tuple[list[Lesson], list[Homework], list[School
|
||||
if not isinstance(start, datetime) or not isinstance(end, datetime):
|
||||
continue
|
||||
|
||||
status = LessonStatus.NORMAL
|
||||
if "Cours - Cours annulé" in categories:
|
||||
status_obj = component.get("status")
|
||||
status_value = str(status_obj).strip().upper() if status_obj is not None else ""
|
||||
if status_value == "CANCELLED" or "Cours - Cours annulé" in categories:
|
||||
status = LessonStatus.CANCELLED
|
||||
elif "Cours - Cours déplacé" in categories:
|
||||
status = LessonStatus.MOVED
|
||||
else:
|
||||
status = LessonStatus.NORMAL
|
||||
|
||||
description = component.get("description")
|
||||
description_str = str(description) if description is not None else ""
|
||||
|
||||
@@ -40,9 +40,8 @@ if TYPE_CHECKING:
|
||||
class _MockPronoteClientProtocol(Protocol):
|
||||
def get_messages(self) -> list[Message]: ...
|
||||
def get_informations(self) -> list[Message]: ...
|
||||
def get_agenda_fallback(
|
||||
self, start: date, end: date
|
||||
) -> tuple[list[Lesson], list[Homework]]: ...
|
||||
def get_lessons(self, start: date, end: date) -> list[Lesson]: ...
|
||||
def get_homeworks(self, start: date, end: date) -> list[Homework]: ...
|
||||
|
||||
|
||||
@pytest.fixture(name="mock_settings")
|
||||
@@ -54,6 +53,7 @@ def fixture_mock_settings() -> Settings:
|
||||
"""
|
||||
return Settings(
|
||||
pronote=PronoteSettings(
|
||||
pronote_url="https://pronote.example.com",
|
||||
ical_url=SecretStr("file:///fake/ical.ics"),
|
||||
agenda_source="auto",
|
||||
homework_source="auto",
|
||||
@@ -128,7 +128,7 @@ def test_fetch_agenda_ical_mode(mock_fetcher: PronoteFetcher) -> None:
|
||||
def test_fetch_agenda_pronotepy_mode(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test la récupération de l'agenda en mode source pronotepy.
|
||||
|
||||
On mock ``get_agenda_fallback`` du client pour retourner des cours.
|
||||
On mock ``get_lessons`` du client pour retourner des cours.
|
||||
On vérifie que le fetcher retourne ces cours (événements scolaires vides).
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
@@ -151,14 +151,14 @@ def test_fetch_agenda_pronotepy_mode(mock_fetcher: PronoteFetcher) -> None:
|
||||
]
|
||||
|
||||
client = MagicMock()
|
||||
client.get_agenda_fallback.return_value = (lessons, [])
|
||||
client.get_lessons.return_value = lessons
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
result_lessons, result_events = mock_fetcher.fetch_agenda()
|
||||
|
||||
assert result_lessons == lessons
|
||||
assert result_events == []
|
||||
client.get_agenda_fallback.assert_called_once()
|
||||
client.get_lessons.assert_called_once()
|
||||
|
||||
|
||||
def test_fetch_agenda_auto_ical_success(mock_fetcher: PronoteFetcher) -> None:
|
||||
@@ -228,13 +228,13 @@ def test_fetch_agenda_auto_fallback_to_pronotepy(mock_fetcher: PronoteFetcher) -
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
client.get_agenda_fallback.return_value = (lessons, [])
|
||||
client.get_lessons.return_value = lessons
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
result_lessons, _ = mock_fetcher.fetch_agenda()
|
||||
|
||||
assert result_lessons == lessons
|
||||
client.get_agenda_fallback.assert_called_once()
|
||||
client.get_lessons.assert_called_once()
|
||||
|
||||
|
||||
def test_fetch_agenda_auto_both_fail(mock_fetcher: PronoteFetcher) -> None:
|
||||
@@ -245,6 +245,9 @@ def test_fetch_agenda_auto_both_fail(mock_fetcher: PronoteFetcher) -> None:
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
# Disable pronotepy so fallback is None
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
@@ -257,19 +260,21 @@ def test_fetch_agenda_auto_both_fail(mock_fetcher: PronoteFetcher) -> None:
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher.fetch_agenda()
|
||||
|
||||
assert "iCal et pronotepy" in str(exc_info.value)
|
||||
assert "la source ical a échoué" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_fetch_agenda_ical_mode_failure(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test le mode ical : échec → PipelineCriticalError masquée.
|
||||
|
||||
On mock iCal pour échouer. On vérifie que l'erreur brute est masquée dans la levée.
|
||||
On mock iCal pour échouer et désactive pronotepy pour que le repli soit None.
|
||||
On vérifie que l'erreur brute est masquée dans la levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
# Override settings to use ical mode explicitly
|
||||
# Override settings to use ical mode explicitly and disable fallback
|
||||
mock_fetcher._settings.pronote.agenda_source = "ical"
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
@@ -283,7 +288,7 @@ def test_fetch_agenda_ical_mode_failure(mock_fetcher: PronoteFetcher) -> None:
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher.fetch_agenda()
|
||||
|
||||
assert "Impossible de récupérer l'agenda : la source iCal a échoué" in str(exc_info.value)
|
||||
assert "Impossible de récupérer l'agenda : la source ical a échoué" in str(exc_info.value)
|
||||
# Vérifie que le message ne contient pas de secret
|
||||
assert "file:///fake/ical.ics" not in str(exc_info.value)
|
||||
|
||||
@@ -291,15 +296,18 @@ def test_fetch_agenda_ical_mode_failure(mock_fetcher: PronoteFetcher) -> None:
|
||||
def test_fetch_agenda_pronotepy_mode_failure(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test le mode pronotepy : échec → PipelineCriticalError masquée.
|
||||
|
||||
On mock pronotepy pour échouer. On vérifie que l'erreur est masquée dans la levée.
|
||||
On mock pronotepy pour échouer et désactive iCal pour que le repli soit None.
|
||||
On vérifie que l'erreur est masquée dans la levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
# Override settings to use pronotepy mode explicitly
|
||||
# Override settings to use pronotepy mode explicitly and disable fallback
|
||||
mock_fetcher._settings.pronote.agenda_source = "pronotepy"
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
|
||||
client = MagicMock()
|
||||
client.get_lessons.side_effect = OSError("Pronote API error")
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
@@ -399,14 +407,14 @@ def test_fetch_homework_auto_fallback(mock_fetcher: PronoteFetcher) -> None:
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
client.get_agenda_fallback.return_value = ([], homeworks)
|
||||
client.get_homeworks.return_value = homeworks
|
||||
mock_fetcher._pronote_client = client
|
||||
m_collect.return_value = homeworks
|
||||
|
||||
result = mock_fetcher.fetch_homework(target_date)
|
||||
|
||||
assert result == homeworks
|
||||
client.get_agenda_fallback.assert_called_once()
|
||||
client.get_homeworks.assert_called_once()
|
||||
|
||||
|
||||
def test_fetch_homework_auto_both_fail(mock_fetcher: PronoteFetcher) -> None:
|
||||
@@ -419,6 +427,9 @@ def test_fetch_homework_auto_both_fail(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""
|
||||
target_date = date(2025, 9, 10)
|
||||
|
||||
# Disable pronotepy so fallback is None
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
@@ -431,7 +442,7 @@ def test_fetch_homework_auto_both_fail(mock_fetcher: PronoteFetcher) -> None:
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher.fetch_homework(target_date)
|
||||
|
||||
assert "iCal et pronotepy" in str(exc_info.value)
|
||||
assert "la source ical a échoué" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_fetch_messages(mock_fetcher: PronoteFetcher) -> None:
|
||||
@@ -457,7 +468,6 @@ def test_fetch_messages(mock_fetcher: PronoteFetcher) -> None:
|
||||
client = MagicMock()
|
||||
client.get_messages.return_value = messages
|
||||
client.get_informations.return_value = []
|
||||
client.get_agenda_fallback.return_value = ([], [])
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
result = mock_fetcher.fetch_messages()
|
||||
@@ -488,7 +498,6 @@ def test_fetch_informations(mock_fetcher: PronoteFetcher) -> None:
|
||||
client = MagicMock()
|
||||
client.get_informations.return_value = infos
|
||||
client.get_messages.return_value = []
|
||||
client.get_agenda_fallback.return_value = ([], [])
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
result = mock_fetcher.fetch_informations()
|
||||
@@ -508,6 +517,9 @@ def test_no_secrets_in_error_messages(
|
||||
:param caplog: Fixture pytest pour capturer les logs.
|
||||
:return: None
|
||||
"""
|
||||
# Disable pronotepy so fallback is None to trigger PipelineCriticalError
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
@@ -529,4 +541,447 @@ def test_no_secrets_in_error_messages(
|
||||
assert "icalsecurise=REDACTED" in caplog.text or "icalsecurise" not in caplog.text
|
||||
|
||||
|
||||
def test_fetch_agenda_ical_mode_fallback_to_pronotepy(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test le mode ICAL : échec iCal, repli sur pronotepy.
|
||||
|
||||
On mock iCal pour échouer, pronotepy pour réussir. On vérifie que pronotepy est appelé.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
start_dt = datetime(2025, 9, 1, 8, 0)
|
||||
end_dt = datetime(2025, 9, 1, 9, 30)
|
||||
lessons = [
|
||||
Lesson(
|
||||
id="l1",
|
||||
start=start_dt,
|
||||
end=end_dt,
|
||||
subject="Maths",
|
||||
teachers=("Dupont",),
|
||||
rooms=("S1",),
|
||||
group="2ndeA",
|
||||
status=LessonStatus.NORMAL,
|
||||
content=None,
|
||||
)
|
||||
]
|
||||
|
||||
# Override settings to use ical mode explicitly
|
||||
mock_fetcher._settings.pronote.agenda_source = "ical"
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
):
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
client.get_lessons.return_value = lessons
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
result_lessons, result_events = mock_fetcher.fetch_agenda()
|
||||
|
||||
assert result_lessons == lessons
|
||||
assert result_events == []
|
||||
client.get_lessons.assert_called_once()
|
||||
|
||||
|
||||
def test_fetch_agenda_pronotepy_mode_fallback_to_ical(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test le mode PRONOTEPY : échec pronotepy, repli sur iCal.
|
||||
|
||||
On mock pronotepy pour échouer, iCal pour réussir. On vérifie que iCal est appelé.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
start_dt = datetime(2025, 9, 1, 8, 0)
|
||||
end_dt = datetime(2025, 9, 1, 9, 30)
|
||||
lessons = [
|
||||
Lesson(
|
||||
id="l1",
|
||||
start=start_dt,
|
||||
end=end_dt,
|
||||
subject="SVT",
|
||||
teachers=("Durand",),
|
||||
rooms=("S2",),
|
||||
group="3emeC",
|
||||
status=LessonStatus.NORMAL,
|
||||
content=None,
|
||||
)
|
||||
]
|
||||
|
||||
# Override settings to use pronotepy mode explicitly
|
||||
mock_fetcher._settings.pronote.agenda_source = "pronotepy"
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
):
|
||||
client = MagicMock()
|
||||
client.get_lessons.side_effect = OSError("Pronote API error")
|
||||
mock_fetcher._pronote_client = client
|
||||
m_fetch_ical.return_value = "BEGIN:VCALENDAR\n..."
|
||||
m_parse_ical.return_value = (lessons, [], [])
|
||||
|
||||
result_lessons, result_events = mock_fetcher.fetch_agenda()
|
||||
|
||||
assert result_lessons == lessons
|
||||
assert result_events == []
|
||||
m_fetch_ical.assert_called_once()
|
||||
m_parse_ical.assert_called_once()
|
||||
|
||||
|
||||
def test_fetch_agenda_no_source_configured_raises(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test le mode AUTO : aucune source configurée → PipelineCriticalError.
|
||||
|
||||
On désactive les deux sources. On vérifie que l'erreur critique est levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
# Disable both sources
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher.fetch_agenda()
|
||||
|
||||
assert "ni la source iCal ni pronotepy n'est configurée" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_fetch_homework_filters_by_target_date(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test que les devoirs sont filtrés par date cible en mode pronotepy.
|
||||
|
||||
On mock pronotepy pour retourner des devoirs avec différentes dates d'échéance.
|
||||
On vérifie que seul le devoir correspondant à la date cible est retourné.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
target_date = date(2025, 9, 10)
|
||||
other_date = date(2025, 9, 11)
|
||||
|
||||
homeworks = [
|
||||
Homework(
|
||||
id="hw1",
|
||||
subject="Maths",
|
||||
teachers=(),
|
||||
assigned_on=None,
|
||||
due_on=target_date,
|
||||
text="Devoir pour aujourd'hui",
|
||||
html="<p>Devoir pour aujourd'hui</p>",
|
||||
),
|
||||
Homework(
|
||||
id="hw2",
|
||||
subject="Physique",
|
||||
teachers=(),
|
||||
assigned_on=None,
|
||||
due_on=other_date,
|
||||
text="Devoir pour demain",
|
||||
html="<p>Devoir pour demain</p>",
|
||||
),
|
||||
]
|
||||
|
||||
client = MagicMock()
|
||||
client.get_homeworks.return_value = homeworks
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
result = mock_fetcher.fetch_homework(target_date)
|
||||
|
||||
assert len(result) == 1
|
||||
assert result[0].id == "hw1"
|
||||
assert result[0].due_on == target_date
|
||||
client.get_homeworks.assert_called_once()
|
||||
|
||||
|
||||
def test_fetch_messages_logs_and_re_raises(
|
||||
mock_fetcher: PronoteFetcher, caplog: pytest.LogCaptureFixture
|
||||
) -> None:
|
||||
"""Test que fetch_messages journalise et relance les exceptions.
|
||||
|
||||
On mock get_messages pour lever une exception contenant une URL secrète.
|
||||
On vérifie que l'exception est relancée et que le log masqué ne contient pas l'URL.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:param caplog: Fixture pytest pour capturer les logs.
|
||||
:return: None
|
||||
"""
|
||||
client = MagicMock()
|
||||
error_msg = "Erreur Pronote : impossible de récupérer les messages https://pronote.example.com/messages?token=SECRET_TOKEN_456"
|
||||
client.get_messages.side_effect = OSError(error_msg)
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
with pytest.raises(OSError) as exc_info:
|
||||
mock_fetcher.fetch_messages()
|
||||
|
||||
assert exc_info.value is client.get_messages.side_effect
|
||||
assert "SECRET_TOKEN_456" not in caplog.text
|
||||
assert (
|
||||
"pronote.example.com/messages?token=REDACTED" in caplog.text
|
||||
or "pronote.example.com/messages" in caplog.text
|
||||
)
|
||||
|
||||
|
||||
def test_fetch_agenda_ical_url_none_raises_value_error(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test que _fetch_agenda_ical lève ValueError si ical_url est None.
|
||||
|
||||
On désactive ical_url et on appelle _fetch_agenda_ical(). On vérifie que
|
||||
l'erreur ValueError est levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
with pytest.raises(ValueError, match="PRONOTE_ICAL_URL est requis pour la source iCal"):
|
||||
mock_fetcher._fetch_agenda_ical()
|
||||
|
||||
|
||||
def test_agenda_sources_auto_only_pronotepy_configured(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test _agenda_sources en mode AUTO avec seulement pronotepy configuré.
|
||||
|
||||
On désactive ical_url mais on garde pronotepy configuré. On vérifie que la
|
||||
source primaire est pronotepy et qu'il n'y a pas de repli.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.agenda_source = "auto"
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
primary, fallback = mock_fetcher._agenda_sources()
|
||||
assert primary == "pronotepy"
|
||||
assert fallback is None
|
||||
|
||||
|
||||
def test_fetch_agenda_fallback_both_fail_raises_pipeline_critical_error(
|
||||
mock_fetcher: PronoteFetcher,
|
||||
) -> None:
|
||||
"""Test que fetch_agenda lève PipelineCriticalError si ICAL échoue et pronotepy aussi.
|
||||
|
||||
On mock ICAL pour échouer, on garde pronotepy configuré mais on mock son échec.
|
||||
On vérifie que l'erreur PipelineCriticalError est levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.agenda_source = "ical"
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
):
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
client.get_lessons.side_effect = OSError("Pronote API error")
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher.fetch_agenda()
|
||||
|
||||
assert "les sources ical et pronotepy ont échoué" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_fetch_agenda_fallback_returns_empty_logs_warning(
|
||||
mock_fetcher: PronoteFetcher, caplog: pytest.LogCaptureFixture
|
||||
) -> None:
|
||||
"""Test que fetch_agenda retourne ([], []) et journalise un avertissement si le repli retourne vide.
|
||||
|
||||
On mock ICAL pour échouer, pronotepy configuré et retourne vide. On vérifie le retour et le log.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:param caplog: Fixture pytest pour capturer les logs.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.agenda_source = "ical"
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
patch(
|
||||
"pronote_sync.sources.pronote.fallback.PronoteFetcher._fetch_agenda_pronotepy"
|
||||
) as m_fetch_pronotepy,
|
||||
):
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
mock_fetcher._pronote_client = client
|
||||
m_fetch_pronotepy.return_value = ([], []) # Empty result from fallback
|
||||
|
||||
lessons, events = mock_fetcher.fetch_agenda()
|
||||
|
||||
assert lessons == []
|
||||
assert events == []
|
||||
assert "a retourné un résultat vide après l'échec de ical" in caplog.text
|
||||
|
||||
|
||||
def test_homework_sources_explicit_ical_mode(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test _homework_sources en mode ICAL.
|
||||
|
||||
On vérifie que la source primaire est ical et que le repli est pronotepy si configuré,
|
||||
ou None sinon.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.homework_source = "ical"
|
||||
|
||||
# With pronotepy configured
|
||||
primary, fallback = mock_fetcher._homework_sources()
|
||||
assert primary == "ical"
|
||||
assert fallback == "pronotepy"
|
||||
|
||||
# Without pronotepy configured
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
primary, fallback = mock_fetcher._homework_sources()
|
||||
assert primary == "ical"
|
||||
assert fallback is None
|
||||
|
||||
|
||||
def test_homework_sources_explicit_pronotepy_mode(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test _homework_sources en mode PRONOTEPY.
|
||||
|
||||
On vérifie que la source primaire est pronotepy et que le repli est ical si configuré,
|
||||
ou None sinon.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.homework_source = "pronotepy"
|
||||
|
||||
# With ical configured
|
||||
primary, fallback = mock_fetcher._homework_sources()
|
||||
assert primary == "pronotepy"
|
||||
assert fallback == "ical"
|
||||
|
||||
# Without ical configured
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
primary, fallback = mock_fetcher._homework_sources()
|
||||
assert primary == "pronotepy"
|
||||
assert fallback is None
|
||||
|
||||
|
||||
def test_homework_sources_auto_only_pronotepy_configured(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test _homework_sources en mode AUTO avec seulement pronotepy configuré.
|
||||
|
||||
On désactive ical_url mais on garde pronotepy configuré. On vérifie que la
|
||||
source primaire est pronotepy et qu'il n'y a pas de repli.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.homework_source = "auto"
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
primary, fallback = mock_fetcher._homework_sources()
|
||||
assert primary == "pronotepy"
|
||||
assert fallback is None
|
||||
|
||||
|
||||
def test_homework_sources_auto_no_source_configured_raises(mock_fetcher: PronoteFetcher) -> None:
|
||||
"""Test _homework_sources en mode AUTO avec aucune source configurée.
|
||||
|
||||
On désactive les deux sources. On vérifie que l'erreur PipelineCriticalError est levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
mock_fetcher._settings.pronote.homework_source = "auto"
|
||||
mock_fetcher._settings.pronote.ical_url = None
|
||||
mock_fetcher._settings.pronote.pronote_url = None
|
||||
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher._homework_sources()
|
||||
|
||||
assert "ni la source iCal ni pronotepy n'est configurée" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_fetch_homework_fallback_both_fail_raises_pipeline_critical_error(
|
||||
mock_fetcher: PronoteFetcher,
|
||||
) -> None:
|
||||
"""Test que fetch_homework lève PipelineCriticalError si ICAL échoue et pronotepy aussi.
|
||||
|
||||
On mock ICAL pour échouer, on garde pronotepy configuré mais on mock son échec.
|
||||
On vérifie que l'erreur PipelineCriticalError est levée.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:return: None
|
||||
"""
|
||||
target_date = date(2025, 9, 10)
|
||||
mock_fetcher._settings.pronote.homework_source = "ical"
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.collect_homeworks") as m_collect,
|
||||
):
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
client.get_homeworks.side_effect = OSError("Pronote API error")
|
||||
mock_fetcher._pronote_client = client
|
||||
m_collect.side_effect = OSError("collect error")
|
||||
|
||||
with pytest.raises(PipelineCriticalError) as exc_info:
|
||||
mock_fetcher.fetch_homework(target_date)
|
||||
|
||||
assert "les sources ical et pronotepy ont échoué" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_fetch_homework_fallback_returns_empty_logs_warning(
|
||||
mock_fetcher: PronoteFetcher, caplog: pytest.LogCaptureFixture
|
||||
) -> None:
|
||||
"""Test que fetch_homework retourne [] et journalise un avertissement si le repli retourne vide.
|
||||
|
||||
On mock ICAL pour échouer, pronotepy configuré et retourne vide. On vérifie le retour et le log.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:param caplog: Fixture pytest pour capturer les logs.
|
||||
:return: None
|
||||
"""
|
||||
target_date = date(2025, 9, 10)
|
||||
mock_fetcher._settings.pronote.homework_source = "ical"
|
||||
|
||||
with (
|
||||
patch("pronote_sync.sources.pronote.fallback.fetch_ical") as m_fetch_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.parse_ical") as m_parse_ical,
|
||||
patch("pronote_sync.sources.pronote.fallback.collect_homeworks") as m_collect,
|
||||
):
|
||||
m_fetch_ical.side_effect = OSError("iCal unreachable")
|
||||
m_parse_ical.side_effect = OSError("iCal parse error")
|
||||
client = MagicMock()
|
||||
mock_fetcher._pronote_client = client
|
||||
m_collect.return_value = [] # Empty result
|
||||
|
||||
result = mock_fetcher.fetch_homework(target_date)
|
||||
|
||||
assert result == []
|
||||
assert "a retourné un résultat vide après l'échec de ical" in caplog.text
|
||||
|
||||
|
||||
def test_fetch_informations_logs_and_re_raises_secret(
|
||||
mock_fetcher: PronoteFetcher, caplog: pytest.LogCaptureFixture
|
||||
) -> None:
|
||||
"""Test que fetch_informations journalise et relance les exceptions avec secret masqué.
|
||||
|
||||
On mock get_informations pour lever une exception contenant une URL secrète.
|
||||
On vérifie que l'exception est relancée et que le log ne contient pas le secret.
|
||||
|
||||
:param mock_fetcher: Fetcher de test.
|
||||
:param caplog: Fixture pytest pour capturer les logs.
|
||||
:return: None
|
||||
"""
|
||||
client = MagicMock()
|
||||
error_msg = "Erreur Pronote : impossible de récupérer les informations https://pronote.example.com/infos?token=SECRET_TOKEN_789"
|
||||
client.get_informations.side_effect = OSError(error_msg)
|
||||
mock_fetcher._pronote_client = client
|
||||
|
||||
with pytest.raises(OSError) as exc_info:
|
||||
mock_fetcher.fetch_informations()
|
||||
|
||||
assert exc_info.value is client.get_informations.side_effect
|
||||
assert "SECRET_TOKEN_789" not in caplog.text
|
||||
assert (
|
||||
"pronote.example.com/infos?token=REDACTED" in caplog.text
|
||||
or "pronote.example.com/infos" in caplog.text
|
||||
)
|
||||
|
||||
|
||||
# Ensure trailing newline
|
||||
|
||||
@@ -26,6 +26,7 @@ from pronote_sync.sources.pronote.ical import (
|
||||
generate_homework_id,
|
||||
get_calendar_name,
|
||||
normalize_homework_text,
|
||||
parse_body,
|
||||
parse_ical,
|
||||
)
|
||||
|
||||
@@ -463,3 +464,137 @@ def test_generate_homework_id_deterministic() -> None:
|
||||
id1 = generate_homework_id(due_on, text)
|
||||
id2 = generate_homework_id(due_on, text)
|
||||
assert id1 == id2
|
||||
|
||||
|
||||
CANCELLED_STATUS_ICAL = """BEGIN:VCALENDAR
|
||||
VERSION:2.0
|
||||
X-WR-CALNAME:Test
|
||||
BEGIN:VEVENT
|
||||
UID:Test-123-20260906T120000Z-Index-Education
|
||||
DTSTART:20260907T080000Z
|
||||
DTEND:20260907T090000Z
|
||||
SUMMARY:Test Course
|
||||
STATUS:CANCELLED
|
||||
DESCRIPTION:<div></div>
|
||||
END:VEVENT
|
||||
END:VCALENDAR"""
|
||||
|
||||
|
||||
NORMAL_STATUS_ICAL = """BEGIN:VCALENDAR
|
||||
VERSION:2.0
|
||||
X-WR-CALNAME:Test
|
||||
BEGIN:VEVENT
|
||||
UID:Test-123-20260906T120000Z-Index-Education
|
||||
DTSTART:20260907T080000Z
|
||||
DTEND:20260907T090000Z
|
||||
SUMMARY:Test Course
|
||||
STATUS:CONFIRMED
|
||||
DESCRIPTION:<div></div>
|
||||
END:VEVENT
|
||||
END:VCALENDAR"""
|
||||
|
||||
|
||||
MOVED_BY_CATEGORY_ICAL = """BEGIN:VCALENDAR
|
||||
VERSION:2.0
|
||||
X-WR-CALNAME:Test
|
||||
BEGIN:VEVENT
|
||||
UID:Test-123-20260906T120000Z-Index-Education
|
||||
DTSTART:20260907T080000Z
|
||||
DTEND:20260907T090000Z
|
||||
SUMMARY:Test Course
|
||||
CATEGORIES:Cours - Cours déplacé
|
||||
DESCRIPTION:<div></div>
|
||||
END:VEVENT
|
||||
END:VCALENDAR"""
|
||||
|
||||
|
||||
MULTIPLE_BLOCKS_SAME_DATE_ICAL = """BEGIN:VCALENDAR
|
||||
VERSION:2.0
|
||||
X-WR-CALNAME:Test
|
||||
BEGIN:VEVENT
|
||||
UID:Test-123-20260906T120000Z-Index-Education
|
||||
DTSTART:20260907T080000Z
|
||||
DTEND:20260907T090000Z
|
||||
SUMMARY:Test Course
|
||||
CATEGORIES:Cours
|
||||
DESCRIPTION:<div>
|
||||
Matière : Math
|
||||
Professeur : M. Dupont
|
||||
Salle : 204
|
||||
|
||||
<strong>Pour le 10/09/2026 :</strong>
|
||||
Exercice 1 à 5 page 42.
|
||||
<strong>Pour le 10/09/2026 :</strong>
|
||||
Exercice 6 à 10 page 43.
|
||||
</div>
|
||||
END:VEVENT
|
||||
END:VCALENDAR"""
|
||||
|
||||
|
||||
def test_parse_ical_status_cancelled_only() -> None:
|
||||
"""Un cours avec STATUS:CANCELLED mais sans CATEGORIES contenant 'Cours annulé' a status == LessonStatus.CANCELLED.
|
||||
|
||||
:return: None
|
||||
"""
|
||||
lessons, _, _ = parse_ical(CANCELLED_STATUS_ICAL)
|
||||
assert len(lessons) == 1
|
||||
assert lessons[0].status == LessonStatus.CANCELLED
|
||||
|
||||
|
||||
def test_parse_ical_status_normal_without_cancel() -> None:
|
||||
"""Un cours avec STATUS:CONFIRMED (ou sans STATUS) a status == LessonStatus.NORMAL.
|
||||
|
||||
:return: None
|
||||
"""
|
||||
lessons, _, _ = parse_ical(NORMAL_STATUS_ICAL)
|
||||
assert len(lessons) == 1
|
||||
assert lessons[0].status == LessonStatus.NORMAL
|
||||
|
||||
|
||||
def test_parse_ical_moved_by_category_only() -> None:
|
||||
"""Un cours avec CATEGORIES:Cours - Cours déplacé et sans STATUS a status == LessonStatus.MOVED.
|
||||
|
||||
:return: None
|
||||
"""
|
||||
lessons, _, _ = parse_ical(MOVED_BY_CATEGORY_ICAL)
|
||||
assert len(lessons) == 1
|
||||
assert lessons[0].status == LessonStatus.MOVED
|
||||
|
||||
|
||||
def test_parse_body_multiple_blocks_same_date() -> None:
|
||||
"""Un DESCRIPTION avec deux sections 'Pour le' à la même date conserve les deux blocs.
|
||||
|
||||
:return: None
|
||||
"""
|
||||
body_html = (
|
||||
"<div>\n"
|
||||
" <strong>Pour le 10/09/2026:</strong>\n"
|
||||
" Exercice 1 à 5 page 42.\n"
|
||||
" <strong>Pour le 10/09/2026:</strong>\n"
|
||||
" Exercice 6 à 10 page 43.\n"
|
||||
"</div>"
|
||||
)
|
||||
content, due_blocks, assigned_blocks = parse_body(body_html)
|
||||
assert len(due_blocks) == 2
|
||||
assert due_blocks[0][0] == date(2026, 9, 10)
|
||||
assert due_blocks[0][1] == "Exercice 1 à 5 page 42."
|
||||
assert due_blocks[1][0] == date(2026, 9, 10)
|
||||
assert due_blocks[1][1] == "Exercice 6 à 10 page 43."
|
||||
|
||||
|
||||
def test_collect_homeworks_from_fixture() -> None:
|
||||
"""Parse le fixture pronote-4e.ics, appelle collect_homeworks pour le 10/09/2026 et vérifie qu'au moins un devoir est retourné.
|
||||
|
||||
:return: None
|
||||
"""
|
||||
fixture_path = Path(__file__).parent.parent / "fixtures" / "pronote-4e.ics"
|
||||
with open(fixture_path, encoding="utf-8") as f:
|
||||
content = f.read()
|
||||
|
||||
lessons, _, _ = parse_ical(content)
|
||||
homeworks = collect_homeworks(lessons, date(2026, 9, 10))
|
||||
|
||||
assert len(homeworks) >= 1
|
||||
# Vérifie qu'au moins un devoir a le bon sujet et texte
|
||||
assert any(hw.subject == "Mathématiques" for hw in homeworks)
|
||||
assert any("Exercices 1 à 5 page 42" in hw.text for hw in homeworks)
|
||||
|
||||
@@ -31,7 +31,8 @@ def test_protocol_methods(mocker: pytest_mock.MockerFixture) -> None:
|
||||
"""
|
||||
assert hasattr(PronoteClientProtocol, "get_messages")
|
||||
assert hasattr(PronoteClientProtocol, "get_informations")
|
||||
assert hasattr(PronoteClientProtocol, "get_agenda_fallback")
|
||||
assert hasattr(PronoteClientProtocol, "get_lessons")
|
||||
assert hasattr(PronoteClientProtocol, "get_homeworks")
|
||||
|
||||
|
||||
# --- Client with mocked pronotepy ---
|
||||
@@ -45,9 +46,11 @@ def pronote_settings() -> PronoteSettings:
|
||||
:rtype: PronoteSettings
|
||||
"""
|
||||
return PronoteSettings(
|
||||
pronote_url="https://pronote.example.com",
|
||||
username="testuser",
|
||||
password=SecretStr("testpass"),
|
||||
ent="testent",
|
||||
ent="bordeaux",
|
||||
account_type="parent",
|
||||
)
|
||||
|
||||
|
||||
@@ -82,7 +85,7 @@ def test_get_messages_success(
|
||||
mock_message.seen = True
|
||||
mock_discussion.messages = [mock_message]
|
||||
mock_client.discussions.return_value = [mock_discussion]
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_messages()
|
||||
@@ -111,7 +114,7 @@ def test_get_messages_empty_on_error(
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.discussions.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_messages()
|
||||
@@ -138,7 +141,7 @@ def test_get_informations_success(
|
||||
mock_info.read = False
|
||||
mock_info.survey = True
|
||||
mock_client.information_and_surveys.return_value = [mock_info]
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_informations()
|
||||
@@ -167,7 +170,7 @@ def test_get_informations_empty_on_error(
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.information_and_surveys.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_informations()
|
||||
@@ -175,10 +178,10 @@ def test_get_informations_empty_on_error(
|
||||
assert messages == []
|
||||
|
||||
|
||||
def test_get_agenda_fallback_success(
|
||||
def test_get_lessons_success(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_agenda_fallback retourne un tuple de listes en cas de succès.
|
||||
"""Vérifie que get_lessons retourne une liste de Lesson en cas de succès.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
@@ -201,20 +204,11 @@ def test_get_agenda_fallback_success(
|
||||
mock_content.description = "Lesson content"
|
||||
mock_lesson.content = mock_content
|
||||
|
||||
# Mock des devoirs
|
||||
mock_hw = mocker.MagicMock()
|
||||
mock_hw.id = "hw-101"
|
||||
mock_hw.subject = mocker.MagicMock()
|
||||
mock_hw.subject.name = "Maths"
|
||||
mock_hw.date = date(2024, 9, 15)
|
||||
mock_hw.description = "Do your homework"
|
||||
|
||||
mock_client.lessons.return_value = [mock_lesson]
|
||||
mock_client.homework.return_value = [mock_hw]
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
lessons, homeworks = client.get_agenda_fallback(date(2024, 9, 1), date(2024, 9, 30))
|
||||
lessons = client.get_lessons(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
assert isinstance(lessons, list)
|
||||
assert len(lessons) == 1
|
||||
@@ -230,6 +224,32 @@ def test_get_agenda_fallback_success(
|
||||
assert lesson.status == LessonStatus.NORMAL
|
||||
assert lesson.content == "Lesson content"
|
||||
|
||||
|
||||
def test_get_homeworks_success(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_homeworks retourne une liste de Homework en cas de succès.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
|
||||
# Mock des devoirs
|
||||
mock_hw = mocker.MagicMock()
|
||||
mock_hw.id = "hw-101"
|
||||
mock_hw.subject = mocker.MagicMock()
|
||||
mock_hw.subject.name = "Maths"
|
||||
mock_hw.date = date(2024, 9, 15)
|
||||
mock_hw.description = "Do your homework"
|
||||
|
||||
mock_client.homework.return_value = [mock_hw]
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
homeworks = client.get_homeworks(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
assert isinstance(homeworks, list)
|
||||
assert len(homeworks) == 1
|
||||
homework = homeworks[0]
|
||||
@@ -243,10 +263,10 @@ def test_get_agenda_fallback_success(
|
||||
assert homework.html == "Do your homework"
|
||||
|
||||
|
||||
def test_get_agenda_fallback_empty_on_error(
|
||||
def test_get_lessons_propagates_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_agenda_fallback retourne des listes vides en cas d'erreur API.
|
||||
"""Vérifie que get_lessons propage les exceptions API.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
@@ -254,91 +274,166 @@ def test_get_agenda_fallback_empty_on_error(
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.lessons.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch("pronotepy.Client", return_value=mock_client)
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
lessons, homeworks = client.get_agenda_fallback(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
assert lessons == []
|
||||
assert homeworks == []
|
||||
with pytest.raises(pronotepy.PronoteAPIError):
|
||||
client.get_lessons(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
|
||||
def test_missing_credentials_returns_empty(empty_pronote_settings: PronoteSettings) -> None:
|
||||
"""Vérifie que les méthodes retournent une liste vide si les identifiants sont manquants.
|
||||
def test_get_homeworks_propagates_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_homeworks propage les exceptions API.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.homework.side_effect = pronotepy.PronoteAPIError("API error")
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
|
||||
with pytest.raises(pronotepy.PronoteAPIError):
|
||||
client.get_homeworks(date(2024, 9, 1), date(2024, 9, 30))
|
||||
|
||||
|
||||
def test_missing_credentials_raises(empty_pronote_settings: PronoteSettings) -> None:
|
||||
"""Vérifie que les appels échouent avec ValueError si les identifiants sont manquants.
|
||||
|
||||
:param empty_pronote_settings: Paramètres Pronote avec tous les champs à None.
|
||||
:return: None
|
||||
"""
|
||||
client = PronoteClient(empty_pronote_settings)
|
||||
|
||||
messages = client.get_messages()
|
||||
assert messages == []
|
||||
|
||||
informations = client.get_informations()
|
||||
assert informations == []
|
||||
|
||||
lessons, homeworks = client.get_agenda_fallback(date(2024, 9, 1), date(2024, 9, 30))
|
||||
assert lessons == []
|
||||
assert homeworks == []
|
||||
with pytest.raises(ValueError, match="pronote_url, username, password et ent sont requis"):
|
||||
client._connect()
|
||||
|
||||
|
||||
def test_password_used_in_connection(
|
||||
def test_connect_with_ent_resolution(mocker: pytest_mock.MockerFixture) -> None:
|
||||
"""Vérifie que _resolve_ent retourne le callable attendu pour un ENT connu.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:return: None
|
||||
"""
|
||||
from pronote_sync.sources.pronote.client import _resolve_ent
|
||||
|
||||
resolver = _resolve_ent("bordeaux")
|
||||
assert resolver is not None
|
||||
|
||||
|
||||
def test_connect_with_unknown_ent_raises(mocker: pytest_mock.MockerFixture) -> None:
|
||||
"""Vérifie que _resolve_ent lève ValueError pour un ENT inconnu.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:return: None
|
||||
"""
|
||||
from pronote_sync.sources.pronote.client import _resolve_ent
|
||||
|
||||
with pytest.raises(ValueError) as exc_info:
|
||||
_resolve_ent("inconnu")
|
||||
assert "ENT inconnu : 'inconnu'" in str(exc_info.value)
|
||||
assert "ENT supportés :" in str(exc_info.value)
|
||||
|
||||
|
||||
def test_connect_parent_account_type(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que le mot de passe est bien utilisé pour la connexion.
|
||||
"""Vérifie que account_type='parent' utilise pronotepy.ParentClient.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
# Patch pronotepy.Client to return our mock
|
||||
from pronote_sync.sources.pronote import client as client_module
|
||||
from unittest.mock import Mock
|
||||
|
||||
from pronote_sync.sources.pronote.client import PronoteClient
|
||||
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_discussion = mocker.MagicMock()
|
||||
mock_message = mocker.MagicMock()
|
||||
mock_message.id = "msg-123"
|
||||
mock_message.content = "Test"
|
||||
mock_message.author = "Teacher"
|
||||
mock_message.created = datetime(2024, 9, 1, 10, 0, 0)
|
||||
mock_message.seen = False
|
||||
mock_discussion.messages = [mock_message]
|
||||
mock_discussion.subject = "Test Subject"
|
||||
mock_client.discussions.return_value = [mock_discussion]
|
||||
|
||||
# Patch pronotepy.Client to return our mock
|
||||
mocker.patch.object(client_module, "pronotepy")
|
||||
client_module.pronotepy.Client = lambda u, p, e: mock_client # type: ignore[attr-defined] # noqa: ARG005
|
||||
|
||||
# Setup mock client
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_discussion = mocker.MagicMock()
|
||||
mock_message = mocker.MagicMock()
|
||||
mock_message.id = "msg-123"
|
||||
mock_message.content = "Test"
|
||||
mock_message.author = "Teacher"
|
||||
mock_message.created = datetime(2024, 9, 1, 10, 0, 0)
|
||||
mock_message.seen = False
|
||||
mock_discussion.messages = [mock_message]
|
||||
mock_discussion.subject = "Test Subject"
|
||||
mock_client.discussions.return_value = [mock_discussion]
|
||||
|
||||
# Patch pronotepy.Client to return our mock
|
||||
mocker.patch("pronote_sync.sources.pronote.client.pronotepy.Client", return_value=mock_client)
|
||||
mock_client_class = Mock(return_value=mock_client)
|
||||
mocker.patch("pronotepy.ParentClient", new=mock_client_class)
|
||||
mocker.patch("pronotepy.Client")
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
_ = client.get_messages()
|
||||
_ = client._connect()
|
||||
|
||||
# Vérifie que le client a été créé avec le mot de passe
|
||||
# Le mock de Client doit avoir été appelé avec username, password, ent
|
||||
client_class_mock = client_module.pronotepy.Client # type: ignore[attr-defined]
|
||||
client_class_mock.assert_called_once()
|
||||
call_args = client_class_mock.call_args
|
||||
assert call_args is not None
|
||||
assert len(call_args.args) >= 3
|
||||
assert call_args.args[0] == "testuser"
|
||||
assert call_args.args[1] == "testpass"
|
||||
assert call_args.args[2] == "testent"
|
||||
# Verify ParentClient was used
|
||||
assert mock_client_class.call_count == 1
|
||||
pronotepy.Client.assert_not_called() # type: ignore[attr-defined]
|
||||
|
||||
|
||||
def test_connect_student_account_type(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que account_type='student' utilise pronotepy.Client.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
from unittest.mock import Mock
|
||||
|
||||
from pronote_sync.sources.pronote.client import PronoteClient
|
||||
|
||||
pronote_settings_student = PronoteSettings(
|
||||
pronote_url="https://pronote.example.com",
|
||||
username="testuser",
|
||||
password=SecretStr("testpass"),
|
||||
ent="bordeaux",
|
||||
account_type="student",
|
||||
)
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client_class = Mock(return_value=mock_client)
|
||||
mocker.patch("pronotepy.Client", new=mock_client_class)
|
||||
mocker.patch("pronotepy.ParentClient")
|
||||
|
||||
client = PronoteClient(pronote_settings_student)
|
||||
_ = client._connect()
|
||||
|
||||
# Verify Client was used
|
||||
assert mock_client_class.call_count == 1
|
||||
pronotepy.ParentClient.assert_not_called() # type: ignore[attr-defined]
|
||||
|
||||
|
||||
def test_get_messages_degraded_on_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_messages retourne une liste vide en cas d'erreur réseau.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.discussions.side_effect = ConnectionError("Network error")
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_messages()
|
||||
|
||||
assert messages == []
|
||||
|
||||
|
||||
def test_get_informations_degraded_on_error(
|
||||
mocker: pytest_mock.MockerFixture, pronote_settings: PronoteSettings
|
||||
) -> None:
|
||||
"""Vérifie que get_informations retourne une liste vide en cas d'erreur réseau.
|
||||
|
||||
:param mocker: Fixture pytest-mock pour le mocking.
|
||||
:param pronote_settings: Paramètres Pronote valides.
|
||||
:return: None
|
||||
"""
|
||||
mock_client = mocker.MagicMock()
|
||||
mock_client.information_and_surveys.side_effect = TimeoutError("Timeout")
|
||||
mocker.patch.object(PronoteClient, "_connect", return_value=mock_client)
|
||||
|
||||
client = PronoteClient(pronote_settings)
|
||||
messages = client.get_informations()
|
||||
|
||||
assert messages == []
|
||||
|
||||
|
||||
# Ensure trailing newline
|
||||
|
||||
Reference in New Issue
Block a user